gh-106529: Support FOR_ITER specializations as uops - #106542
Closed
gvanrossum wants to merge 4 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
11 tasks
Copy link
Copy Markdown
Member
Author
|
Closing this version, we have to rethink this (see #106529 (comment)). |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another piece extracted from gh-106393. Without either this or an implementation of the POP_JUMP_IF_XXX part of gh-106529, the (in itself much simpler) JUMP_BACKWARD part (gh-106543) isn't useful or testable.
Once gh-106543 is merged, the test for this is simple: add a check for JUMP_TO_TOP to the test for FOR_ITER_RANGE.