GH-106529: Define POP_JUMP_IF_NONE in terms of POP_JUMP_IF_TRUE - #106599
Merged
markshannon merged 3 commits intoJul 11, 2023
Merged
GH-106529: Define POP_JUMP_IF_NONE in terms of POP_JUMP_IF_TRUE#106599markshannon merged 3 commits into
markshannon merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
11 tasks
gvanrossum
approved these changes
Jul 10, 2023
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Great, this should work with gh-106551 once that's ready.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
FWIW, I tried to come up with a test case for this, and finally realized these two opcodes are only emitted by compile.c for except*... |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I pushed merge (since the conflict was my fault) but I'll leave it to you to land. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Likewise POP_JUMP_IF_NOT_NONE in terms of POP_JUMP_IF_FALSE.