FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-105481: expose opcode metadata via the _opcode module by iritkatriel · Pull Request #106688 · python/cpython · GitHub

/ cpython Public

gh-105481: expose opcode metadata via the _opcode module - #106688

Merged
iritkatriel merged 10 commits into
python:mainfrom
iritkatriel:expose_metadata
Jul 14, 2023
ConversationCommits (10)ChecksFiles changed
Merged

gh-105481: expose opcode metadata via the _opcode module#106688
iritkatriel merged 10 commits into
python:mainfrom
iritkatriel:expose_metadata

Conversation

iritkatriel commented Jul 12, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

iritkatriel requested a review from gvanrossum July 12, 2023 18:47
bedevere-bot mentioned this pull request Jul 12, 2023
Closed
iritkatriel requested a review from markshannon as a code owner July 12, 2023 20:35
iritkatriel marked this pull request as draft July 12, 2023 20:40

iritkatriel commented Jul 12, 2023

Copy link
Copy Markdown
Member Author

There's a problem here with the definition of the metadata table. I'll try to sort it out tomorrow.

iritkatriel marked this pull request as ready for review July 14, 2023 14:39
gvanrossum approved these changes Jul 14, 2023
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Something worries me about the amount of repetition for each flag. But the alternative (exposing the flags as an int, and the constants) seems worse. So go for it!

iritkatriel commented Jul 14, 2023

Copy link
Copy Markdown
Member Author

Yes, I didn't want to expose the bitmap implementation.

iritkatriel merged commit 6a70edf into python:main Jul 14, 2023
iritkatriel deleted the expose_metadata branch July 25, 2023 18:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes
markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL