FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104050: Argument Clinic: Annotate nested function parser_body() in the CLanguage class by erlend-aasland · Pull Request #106699 · python/cpython · GitHub

/ cpython Public

gh-104050: Argument Clinic: Annotate nested function parser_body() in the CLanguage class #106699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 1 commit into from
Jul 12, 2023
Conversation 1 Commits 1 Checks 0 Files changed
Merged

gh-104050: Argument Clinic: Annotate nested function parser_body() in the CLanguage class #106699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
18 changes: 10 additions & 8 deletions Tools/clinic/clinic.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -898,22 +898,24 @@ def output_templates(self, f):
# parser_body_fields remembers the fields passed in to the
# previous call to parser_body. this is used for an awful hack.
parser_body_fields = ()
def parser_body(prototype, *fields, declarations=''):
def parser_body(
prototype: str,
*fields: str,
declarations: str = ''
) -> str:
nonlocal parser_body_fields
add, output = text_accumulator()
add(prototype)
parser_body_fields = fields

fields = list(fields)
fields.insert(0, normalize_snippet("""
preamble = normalize_snippet("""
{{
{return_value_declaration}
{parser_declarations}
{declarations}
{initializers}
""") + "\n")
# just imagine--your code is here in the middle
fields.append(normalize_snippet("""
""") + "\n"
finale = normalize_snippet("""
{modifications}
{return_value} = {c_basename}_impl({impl_arguments});
{return_conversion}
Expand All @@ -923,8 +925,8 @@ def parser_body(prototype, *fields, declarations=''):
{cleanup}
return return_value;
}}
"""))
for field in fields:
""")
for field in preamble, *fields, finale:

AlexWaygood Jul 12, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nice!
add('\n')
add(field)
return linear_format(output(), parser_declarations=declarations)
Expand Down
Back | FazBrowse Home | New Git URL