FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104050: Argument Clinic: Annotate Clinic.parse() by erlend-aasland · Pull Request #106760 · python/cpython · GitHub

/ cpython Public

gh-104050: Argument Clinic: Annotate Clinic.parse() - #106760

Merged
erlend-aasland merged 6 commits into
python:mainfrom
erlend-aasland:clinic/annotate-clinic-parse
Jul 17, 2023
ConversationCommits (6)ChecksFiles changed
Merged

gh-104050: Argument Clinic: Annotate Clinic.parse()#106760
erlend-aasland merged 6 commits into
python:mainfrom
erlend-aasland:clinic/annotate-clinic-parse

Conversation

erlend-aasland commented Jul 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

pythongh-104050: Argument Clinic: Annotate Clinic.parse()
dd434fb 
As a consequence, also add a generic Parser ABC
bedevere-bot mentioned this pull request Jul 14, 2023
Closed
AlexWaygood reviewed Jul 15, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Outdated
erlend-aasland commented Jul 15, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Outdated
AlexWaygood approved these changes Jul 16, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Some small nitpicks, but nothing blocking!

Comment thread Tools/clinic/clinic.py
Comment thread Tools/clinic/clinic.py Outdated
erlend-aasland and others added 2 commits July 17, 2023 01:25
Apply suggestions from code review
2c9075d 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Update Tools/clinic/clinic.py
96dae0c 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
erlend-aasland enabled auto-merge (squash) July 16, 2023 23:27
erlend-aasland merged commit 383dcbe into python:main Jul 17, 2023
erlend-aasland deleted the clinic/annotate-clinic-parse branch July 17, 2023 11:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL