FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-106919: Use role :c:macro: for referencing the C "constants" by serhiy-storchaka · Pull Request #106920 · python/cpython · GitHub

/ cpython Public

gh-106919: Use role :c:macro: for referencing the C "constants" - #106920

Merged
serhiy-storchaka merged 4 commits into
python:mainfrom
serhiy-storchaka:docs-c-macro-roles
Jul 21, 2023
ConversationCommits (4)ChecksFiles changed
Merged

gh-106919: Use role :c:macro: for referencing the C "constants"#106920
serhiy-storchaka merged 4 commits into
python:mainfrom
serhiy-storchaka:docs-c-macro-roles

Conversation

serhiy-storchaka commented Jul 20, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request Jul 20, 2023
Closed
bedevere-bot added awaiting core review docs Documentation in the Doc dir labels Jul 20, 2023
erlend-aasland reviewed Jul 20, 2023
View reviewed changes
Comment thread Doc/c-api/slice.rst Outdated
Comment thread Doc/c-api/exceptions.rst Outdated
Comment thread Doc/c-api/exceptions.rst Outdated
Comment thread Doc/c-api/call.rst
serhiy-storchaka and others added 2 commits July 20, 2023 21:36
Apply suggestions from code review
d41eba4 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Use explicit label names in references.
c16e6e4
erlend-aasland reviewed Jul 20, 2023
View reviewed changes
Comment thread Doc/c-api/arg.rst

It is possible to pass "long" integers (integers whose value exceeds the
platform's :const:`LONG_MAX`) however no proper range checking is done --- the
platform's :c:macro:`LONG_MAX`) however no proper range checking is done --- the

erlend-aasland Jul 20, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
platform's :c:macro:`LONG_MAX`) however no proper range checking is done --- the
platform's :c:macro:`!LONG_MAX`) however no proper range checking is done --- the

serhiy-storchaka Jul 21, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think that it may be better to solve this for standard C names globally.

Comment thread Doc/c-api/call.rst
erlend-aasland approved these changes Jul 20, 2023
View reviewed changes

erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, with one nit. Thanks!

ezio-melotti approved these changes Jul 21, 2023
View reviewed changes

ezio-melotti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

Comment thread Doc/c-api/structures.rst Outdated
Update Doc/c-api/structures.rst
81b5927 
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
serhiy-storchaka merged commit fcc816d into python:main Jul 21, 2023

miss-islington commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

serhiy-storchaka deleted the docs-c-macro-roles branch July 21, 2023 07:52

miss-islington commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker fcc816dbff7ca66c26f57a506e4d2330fe41d0ff 3.12

miss-islington commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker fcc816dbff7ca66c26f57a506e4d2330fe41d0ff 3.11

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 21, 2023
[3.12] pythongh-106919: Use role :c:macro: for referencing the C "con…
ae8937a 
…stants" (pythonGH-106920).

(cherry picked from commit fcc816d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-bot commented Jul 21, 2023

Copy link
Copy Markdown

GH-106951 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 21, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 21, 2023
[3.11] pythongh-106919: Use role :c:macro: for referencing the C "con…
039e3fc 
…stants" (pythonGH-106920).

(cherry picked from commit fcc816d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-bot commented Jul 21, 2023

Copy link
Copy Markdown

GH-106952 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 21, 2023
serhiy-storchaka added a commit that referenced this pull request Jul 21, 2023
[3.12] gh-106919: Use role :c:macro: for referencing the C "constants" (
ac9aa8a 
GH-106920) (GH-106951)

(cherry picked from commit fcc816d)
serhiy-storchaka added a commit that referenced this pull request Jul 21, 2023
[3.11] gh-106919: Use role :c:macro: for referencing the C "constants" (
6bde1b9 
GH-106920) (GH-106952)

(cherry picked from commit fcc816d)
serhiy-storchaka removed their assignment Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland erlend-aasland approved these changes
ezio-melotti ezio-melotti approved these changes
vstinner Awaiting requested review from vstinner
encukou Awaiting requested review from encukou encukou is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL