FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104050: Argument Clinic: Annotate CLanguage.render_option_group_parsing() by erlend-aasland · Pull Request #106929 · python/cpython · GitHub

/ cpython Public

gh-104050: Argument Clinic: Annotate CLanguage.render_option_group_parsing() - #106929

Merged
erlend-aasland merged 4 commits into
python:mainfrom
erlend-aasland:clinic/annotate-clanguage-render-option-group-parsing
Jul 20, 2023
ConversationCommits (4)ChecksFiles changed
Merged

gh-104050: Argument Clinic: Annotate CLanguage.render_option_group_parsing()#106929
erlend-aasland merged 4 commits into
python:mainfrom
erlend-aasland:clinic/annotate-clanguage-render-option-group-parsing

Conversation

erlend-aasland commented Jul 20, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot mentioned this pull request Jul 20, 2023
Closed
AlexWaygood reviewed Jul 20, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Some unnecessary use of quoted annotations now that we have from __future__ import annotations at the top of the file:

Comment thread Tools/clinic/clinic.py Outdated
Comment thread Tools/clinic/clinic.py Outdated
AlexWaygood reviewed Jul 20, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py
erlend-aasland commented Jul 20, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Outdated
erlend-aasland commented Jul 20, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py
erlend-aasland and others added 2 commits July 20, 2023 22:52
Apply suggestions from code review
a13d26b 
Extra quotes around Parameter are not needed anymore

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Apply suggestions from code review
4fa647e 
Rip out ParamIter
AlexWaygood reviewed Jul 20, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py
group = required
else:
right.append(group)
assert group is not None

AlexWaygood Jul 20, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is fine for now, but I feel like there's probably a simpler way of writing the code immediately above that would be easier to understand and not require this assertion here for mypy

erlend-aasland Jul 20, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes. We should accumulate these smells in the modernising-issue, so we don't forget. Or we can just grep for asserts.

Comment thread Tools/clinic/clinic.py Outdated
🤦
5fe6c3f 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood approved these changes Jul 20, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks!

erlend-aasland commented Jul 20, 2023

Copy link
Copy Markdown
Contributor Author

LGTM, thanks!

Thanks, the same!

erlend-aasland enabled auto-merge (squash) July 20, 2023 21:13
erlend-aasland merged commit 42c6300 into python:main Jul 20, 2023
erlend-aasland deleted the clinic/annotate-clanguage-render-option-group-parsing branch July 20, 2023 21:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL