FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104050: Argument Clinic: Annotate the BufferSeries class by erlend-aasland · Pull Request #106935 · python/cpython · GitHub

/ cpython Public

gh-104050: Argument Clinic: Annotate the BufferSeries class - #106935

Merged
erlend-aasland merged 5 commits into
python:mainfrom
erlend-aasland:clinic/annotate-buffer-series
Jul 22, 2023
ConversationCommits (5)ChecksFiles changed
Merged

gh-104050: Argument Clinic: Annotate the BufferSeries class#106935
erlend-aasland merged 5 commits into
python:mainfrom
erlend-aasland:clinic/annotate-buffer-series

Conversation

erlend-aasland commented Jul 20, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot mentioned this pull request Jul 20, 2023
Closed
AlexWaygood reviewed Jul 20, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py
erlend-aasland changed the title gh-104050: Argument Clinic: Annotate BufferSeries class gh-104050: Argument Clinic: Annotate the BufferSeries class Jul 20, 2023
serhiy-storchaka approved these changes Jul 21, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Outdated
Comment on lines +1973 to +1976
def __getitem__(
self,
i: int
) -> _TextAccumulator:

serhiy-storchaka Jul 21, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why not write it in one line? It is still pretty short.

erlend-aasland Jul 21, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sure; I have not yet developed a preference when it comes to annotation style :)

AlexWaygood Jul 21, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

FWIW, I agree with Serhiy — I would probably put this all on one line — but I also don't really care much either way (life's too short to spend it arguing over code formatting preferences 😄)

erlend-aasland Jul 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

(life's too short to spend it arguing over code formatting preferences 😄)

No, it isn't! 😆

erlend-aasland mentioned this pull request Jul 21, 2023
Closed

erlend-aasland commented Jul 21, 2023

Copy link
Copy Markdown
Contributor Author

On hold until #106972 has landed.

AlexWaygood approved these changes Jul 22, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

erlend-aasland merged commit c5adf26 into python:main Jul 22, 2023

erlend-aasland commented Jul 22, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the reviews!

erlend-aasland deleted the clinic/annotate-buffer-series branch July 22, 2023 10:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes
AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL