FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-106368: Increase coverage for Argument Clinic output directive by erlend-aasland · Pull Request #106979 · python/cpython · GitHub

/ cpython Public

gh-106368: Increase coverage for Argument Clinic output directive - #106979

Merged
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:clinic/coverage-output-directive
Jul 22, 2023
ConversationCommits (2)ChecksFiles changed
Merged

gh-106368: Increase coverage for Argument Clinic output directive#106979
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:clinic/coverage-output-directive

Conversation

erlend-aasland commented Jul 21, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

erlend-aasland requested a review from sobolevn July 21, 2023 21:57
bedevere-bot mentioned this pull request Jul 21, 2023
Closed
bedevere-bot added the tests Tests in the Lib/test dir label Jul 21, 2023
sobolevn approved these changes Jul 22, 2023
View reviewed changes

sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

My question is not blocking :)
Thanks!

Comment thread Lib/test/test_clinic.py

erlend-aasland commented Jul 22, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the reviews!

erlend-aasland enabled auto-merge (squash) July 22, 2023 09:06
erlend-aasland merged commit ee5c01b into python:main Jul 22, 2023

miss-islington commented Jul 22, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington commented Jul 22, 2023

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ee5c01b473eeadb007b9f330db3143e34e46038b 3.11

bedevere-bot commented Jul 22, 2023

Copy link
Copy Markdown

GH-106994 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 22, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2023
pythongh-106368: Increase coverage for Argument Clinic output directi…
483c3d6 
…ve (pythonGH-106979)

(cherry picked from commit ee5c01b)

Co-authored-by: Erlend E. Aasland <erlend@python.org>

bedevere-bot commented Jul 22, 2023

Copy link
Copy Markdown

GH-107002 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 22, 2023
ambv pushed a commit to ambv/cpython that referenced this pull request Jul 22, 2023
[3.11] pythongh-106368: Increase coverage for Argument Clinic output …
42dd5ce 
…directive (pythonGH-106979)

(cherry picked from commit ee5c01b)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull request Jul 22, 2023
[3.12] gh-106368: Increase coverage for Argument Clinic output direct…
76fd98a 
…ive (GH-106979) (#106994)

(cherry picked from commit ee5c01b)

Co-authored-by: Erlend E. Aasland <erlend@python.org>

erlend-aasland commented Jul 22, 2023

Copy link
Copy Markdown
Contributor Author

I'll fix the backport later, unless someone beats me to it :)

ambv added a commit that referenced this pull request Jul 22, 2023
[3.11] gh-106368: Increase coverage for Argument Clinic output direct…
06f8a43 
…ive (GH-106979) (#107002)

(cherry picked from commit ee5c01b)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland deleted the clinic/coverage-output-directive branch July 22, 2023 14:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ambv ambv left review comments
sobolevn sobolevn approved these changes
AlexWaygood Awaiting requested review from AlexWaygood

Assignees

erlend-aasland

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL