Repository navigation
gh-105535 Document potential performance trap during enum creation - #107119
Merged
ethanfurman merged 11 commits intoMar 8, 2024
Merged
ethanfurman merged 11 commits into
ethanfurman merged 11 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
evildmp
reviewed
Jul 23, 2023
Comment thread
Doc/library/enum.rst
Outdated
evildmp
approved these changes
Jul 23, 2023
ethanfurman
reviewed
Jul 24, 2023
Comment thread
Doc/library/enum.rst
Outdated
evildmp
suggested changes
Jul 24, 2023
Comment thread
Doc/library/enum.rst
Outdated
ethanfurman
reviewed
Jul 24, 2023
Comment thread
Doc/library/enum.rst
Outdated
Copy link
Copy Markdown
Member
|
Thoughts on making this an actual warning box? |
Sorry, something went wrong.
hugovk
reviewed
Jul 24, 2023
Comment thread
Doc/library/enum.rst
Outdated
ethanfurman
reviewed
Jul 25, 2023
Comment thread
Doc/library/enum.rst
Outdated
attempt to fix dataclass link
evildmp
approved these changes
Jul 26, 2023
ethanfurman
reviewed
Mar 4, 2024
Comment thread
Doc/library/enum.rst
Outdated
ethanfurman
reviewed
Mar 4, 2024
Comment thread
Doc/library/enum.rst
Outdated
hugovk
reviewed
Mar 5, 2024
Comment thread
Doc/library/enum.rst
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Copy link
Copy Markdown
Member
|
@hugovk, thanks, I missed that those were the sunder versions when I merged them. |
Sorry, something went wrong.
hugovk
reviewed
Mar 5, 2024
Comment thread
Doc/library/enum.rst
Outdated
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk
approved these changes
Mar 6, 2024
Copy link
Copy Markdown
|
Thanks @nicky-eng for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 8, 2024
…ion (pythonGH-107119) (cherry picked from commit 601f3a7) Co-authored-by: Nicolas A. Oyarzabal <79150521+nicky-eng@users.noreply.github.com> Co-authored-by: Ethan Furman <ethan@stoneleaf.us> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-116511 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 8, 2024
…ion (pythonGH-107119) (cherry picked from commit 601f3a7) Co-authored-by: Nicolas A. Oyarzabal <79150521+nicky-eng@users.noreply.github.com> Co-authored-by: Ethan Furman <ethan@stoneleaf.us> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-116512 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
…ion (pythonGH-107119) Co-authored-by: Ethan Furman <ethan@stoneleaf.us> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…ion (pythonGH-107119) Co-authored-by: Ethan Furman <ethan@stoneleaf.us> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #105535
Document potential performance trap during enum creation.
📚 Documentation preview 📚: https://cpython-previews--107119.org.readthedocs.build/