FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix the documentation for PyCode_New by da-woods · Pull Request #107186 · python/cpython · GitHub

/ cpython Public

Fix the documentation for PyCode_New - #107186

Merged
kumaraditya303 merged 2 commits into
python:mainfrom
da-woods:patch-1
Jul 29, 2023
ConversationCommits (2)ChecksFiles changed
Merged

Fix the documentation for PyCode_New#107186
kumaraditya303 merged 2 commits into
python:mainfrom
da-woods:patch-1

Conversation

da-woods commented Jul 24, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

The signature is incorrectly documented from Python 3.11 upwards - it also adds the qualname parameter

📚 Documentation preview 📚: https://cpython-previews--107186.org.readthedocs.build/

Fix the documentation for PyCode_New
85594b8 
The signature is incorrectly documented from Python 3.11 upwards - it also adds the `qualname` parameter
bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 24, 2023
da-woods commented Jul 24, 2023
View reviewed changes
Comment thread Doc/c-api/code.rst Outdated
kumaraditya303 merged commit f2abeb5 into python:main Jul 29, 2023
kumaraditya303 added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 29, 2023

miss-islington commented Jul 29, 2023

Copy link
Copy Markdown
Contributor

Thanks @da-woods for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented Jul 29, 2023

Copy link
Copy Markdown
Contributor

Thanks @da-woods for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington commented Jul 29, 2023

Copy link
Copy Markdown
Contributor

Sorry, @da-woods and @kumaraditya303, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f2abeb590dae5918388f91b60b31f040d44218f0 3.11

bedevere-bot commented Jul 29, 2023

Copy link
Copy Markdown

GH-107440 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 29, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 29, 2023
Fix the documentation for PyCode_New add qualname parameter (python…
b39c9a4 
…GH-107186)

(cherry picked from commit f2abeb5)

Co-authored-by: da-woods <dw-git@d-woods.co.uk>
da-woods deleted the patch-1 branch July 29, 2023 17:47
kumaraditya303 pushed a commit that referenced this pull request Jul 29, 2023
[3.12] Fix the documentation for PyCode_New add qualname parameter (G…
e3b5ed7 
…H-107186) (#107440)

Fix the documentation for PyCode_New add `qualname` parameter (GH-107186)
(cherry picked from commit f2abeb5)

Co-authored-by: da-woods <dw-git@d-woods.co.uk>
da-woods mentioned this pull request Jul 30, 2023
Merged

bedevere-bot commented Jul 30, 2023

Copy link
Copy Markdown

GH-107454 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 30, 2023
kumaraditya303 pushed a commit that referenced this pull request Jul 30, 2023
[3.11] Fix the documentation for PyCode_New add qualname parameter (G…
ff5dd9d 
…H-107186) (#107454)

[3.11] Fix the documentation for PyCode_New add `qualname` parameter (GH-107186).
(cherry picked from commit f2abeb5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kumaraditya303 kumaraditya303 approved these changes

Assignees

kumaraditya303

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL