Repository navigation
gh-104050: Argument clinic: misc improvements to type annotation coverage - #107206
Merged
AlexWaygood merged 1 commit intoJul 24, 2023
Merged
AlexWaygood merged 1 commit into
AlexWaygood merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Comment thread
Tools/clinic/clinic.py
| # these F spaces will be stripped. | ||
| def state_parameter_docstring(self, line): | ||
| def state_parameter_docstring(self, line: str | None) -> None: | ||
| assert line is not None |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
We need to get rid of these at some point.
Sorry, something went wrong.
erlend-aasland
approved these changes
Jul 24, 2023
erlend-aasland
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
🚀
Sorry, something went wrong.
AlexWaygood
enabled auto-merge (squash)
July 24, 2023 21:20
jtcave
pushed a commit
to jtcave/cpython
that referenced
this pull request
Jul 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets us down to 22 remaining errors if you run mypy with --disallow-untyped-defs!