FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-106004: PyDict_GetItemRef() should only be in the limited API 3.13 by serhiy-storchaka · Pull Request #107229 · python/cpython · GitHub

/ cpython Public

gh-106004: PyDict_GetItemRef() should only be in the limited API 3.13 - #107229

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:limited-capi-PyDict_GetItemRef
Jul 25, 2023
ConversationCommits (1)ChecksFiles changed
Merged

gh-106004: PyDict_GetItemRef() should only be in the limited API 3.13#107229
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:limited-capi-PyDict_GetItemRef

Conversation

serhiy-storchaka commented Jul 25, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request Jul 21, 2023
Closed
serhiy-storchaka force-pushed the limited-capi-PyDict_GetItemRef branch from b0233b5 to 4210c15 Compare July 25, 2023 10:49
vstinner reviewed Jul 25, 2023
View reviewed changes
Comment thread Include/dictobject.h Outdated

vstinner commented Jul 25, 2023

Copy link
Copy Markdown
Member

Oh sorry, I always forget to pay attention to versionning when adding a function to the limited C API.

serhiy-storchaka changed the title gh-106004: PyDict_GetItemRef() should only be in the limited API 3.13 gh-106004: PyDict_GetItemRef() should only be in the limited API 3.10 Jul 25, 2023
serhiy-storchaka changed the title gh-106004: PyDict_GetItemRef() should only be in the limited API 3.10 gh-106004: PyDict_GetItemRef() should only be in the limited API 3.13 Jul 25, 2023
serhiy-storchaka force-pushed the limited-capi-PyDict_GetItemRef branch from 4210c15 to 6730eec Compare July 25, 2023 11:07
vstinner approved these changes Jul 25, 2023
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thanks for the fix.

serhiy-storchaka merged commit 2b1a81e into python:main Jul 25, 2023
serhiy-storchaka deleted the limited-capi-PyDict_GetItemRef branch July 25, 2023 18:48
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
pythongh-106004: PyDict_GetItemRef() should only be in the limited AP…
af34f7d 
…I 3.13 (pythonGH-107229)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL