FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-107082: Fix instruction size computation for ENTER_EXECUTOR by gvanrossum · Pull Request #107256 · python/cpython · GitHub

/ cpython Public

gh-107082: Fix instruction size computation for ENTER_EXECUTOR - #107256

Merged
gvanrossum merged 2 commits into
python:mainfrom
gvanrossum:fix-capi-crash
Jul 25, 2023
ConversationCommits (2)ChecksFiles changed
Merged

gh-107082: Fix instruction size computation for ENTER_EXECUTOR#107256
gvanrossum merged 2 commits into
python:mainfrom
gvanrossum:fix-capi-crash

Conversation

gvanrossum commented Jul 25, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request Jul 25, 2023
Closed
gvanrossum added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jul 25, 2023

bedevere-bot commented Jul 25, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gvanrossum for commit 92b493d 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 25, 2023

vstinner commented Jul 25, 2023

Copy link
Copy Markdown
Member

I tested manually the change on ppc64. I confirm that this change fix ./python -m test -v test_capi on big endian machine.

I built Python with ./configure --with-pydebug && make -j32: it builds C code with gcc -Og, GCC 13.1.0 on Debian Sid.

Without the fix, I am able to reproduce the issue.

vstinner approved these changes Jul 25, 2023
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. The change retrieves the original opcode stored in executors by insert_executor().

Comment thread Python/instrumentation.c Outdated
Rewrite for readability
7e8208c 
Co-authored-by: Victor Stinner <vstinner@python.org>
gvanrossum enabled auto-merge (squash) July 25, 2023 19:26
gvanrossum mentioned this pull request Jul 25, 2023
Closed
10 tasks
gvanrossum merged commit 233b878 into python:main Jul 25, 2023
gvanrossum deleted the fix-capi-crash branch July 25, 2023 20:06

vstinner commented Jul 25, 2023

Copy link
Copy Markdown
Member

Thanks for the fix.

jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
pythongh-107082: Fix instruction size computation for ENTER_EXECUTOR (p…
659aed0 
…ython#107256)

Co-authored-by: Victor Stinner <vstinner@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
markshannon Awaiting requested review from markshannon

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_capi: test_extended_arg() failed on PPC64LE RHEL7 Refleaks 3.x

3 participants

Back | FazBrowse Home | New Git URL