gh-105481: add OPCODE_IS_INSTRUMENTED (generated from bytecodes.c) to replace MIN_INSTRUMENTED_OPCODE (defined in opcode.py) - #107276
Closed
iritkatriel wants to merge 4 commits into
Closed
Conversation
….c) to replace MIN_INSTRUMENTED_OPCODE (defined in opcode.py)
iritkatriel
force-pushed
the
instrumented
branch
from
91ef606 to
02f7a9f
Compare
July 26, 2023 12:58
iritkatriel
commented
Jul 26, 2023
Comment thread
Tools/cases_generator/generate_cases.py
| " (((OP) >= 0) && ((OP) < OPCODE_METADATA_SIZE) && \\\n" | ||
| " (_PyOpcode_opcode_metadata[(OP)].valid_entry))" | ||
| " (_PyOpcode_opcode_metadata[(OP)].valid_entry)) || \\\n" | ||
| " ((OP) == INSTRUMENTED_LINE)" # implemented in ceval.c, not bytecodes.c |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
I had to special-case INSTRUMENTED_LINE because it's implemented in ceval.c rather than bytecodes.c, so doesn't appear in the metadata. We could instead do something else like add it to the instr list after bytecode.c is parsed. I'm not sure which option is less bad.
Sorry, something went wrong.
iritkatriel
marked this pull request as draft
July 26, 2023 15:42
Copy link
Copy Markdown
Member
Author
|
After speaking to @markshannon I decided not to add this metadata but to generate MIN_INSTRUMENTED_OPCODE to replicate what we have now. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.