[3.12] gh-101524: Only Use Public C-API in the _xxsubinterpreters Module (gh-105258) - #107303
Merged
ericsnowcurrently merged 2 commits intoJul 27, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…le (pythongh-105258) The _xxsubinterpreters module was meant to only use public API. Some internal C-API usage snuck in over the last few years (e.g. pythongh-28969). This fixes that. (cherry picked from commit e6373c0) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
This was referenced Jul 26, 2023
Copy link
Copy Markdown
Member
|
This change allows me to independently build the _xxsubinterpreters module against 3.12 without Py_BUILD_CORE, for publishing to PyPI. |
Sorry, something went wrong.
Yhg1s
reviewed
Jul 27, 2023
Comment thread
Modules/_xxinterpchannelsmodule.c
Yhg1s
approved these changes
Jul 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _xxsubinterpreters module was meant to only use public API. Some internal C-API usage snuck in over the last few years (e.g. gh-28969). This fixes that.
(cherry picked from commit e6373c0)
Co-authored-by: Eric Snow ericsnowcurrently@gmail.com