FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-107091: Fix some uses of :const: role by serhiy-storchaka · Pull Request #107379 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-107091: Fix some uses of :const: role - #107379

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:docs-const-role
Jul 28, 2023
ConversationCommits (1)ChecksFiles changed
Merged

gh-107091: Fix some uses of :const: role#107379
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:docs-const-role

Conversation

serhiy-storchaka commented Jul 28, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

It is for references, not for literals.

📚 Documentation preview 📚: https://cpython-previews--107379.org.readthedocs.build/

serhiy-storchaka added docs Documentation in the Doc dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 28, 2023
serhiy-storchaka requested a review from vsajip as a code owner July 28, 2023 08:10
bedevere-bot mentioned this pull request Jul 28, 2023
Closed
pythongh-107091: Fix some uses of :const: role
b97bfea 
It is for references, not for literals.
vstinner approved these changes Jul 28, 2023
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. The old usage of const looks suspicious and wrong. Congrats for fixing one more file in Doc/tools/.nitignore, for me a single fixed file is already a great success!

serhiy-storchaka merged commit 0aa58fa into python:main Jul 28, 2023

miss-islington commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

serhiy-storchaka deleted the docs-const-role branch July 28, 2023 10:26

bedevere-bot commented Jul 28, 2023

Copy link
Copy Markdown

GH-107384 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2023
pythongh-107091: Fix some uses of :const: role (pythonGH-107379)
6ada8ed 
It is for references, not for literals.
(cherry picked from commit 0aa58fa)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 28, 2023

bedevere-bot commented Jul 28, 2023

Copy link
Copy Markdown

GH-107385 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 28, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2023
pythongh-107091: Fix some uses of :const: role (pythonGH-107379)
dcc8a97 
It is for references, not for literals.
(cherry picked from commit 0aa58fa)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Jul 28, 2023
[3.12] gh-107091: Fix some uses of :const: role (GH-107379) (GH-107384)
0f42f41 
It is for references, not for literals.
(cherry picked from commit 0aa58fa)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

serhiy-storchaka commented Jul 28, 2023

Copy link
Copy Markdown
Member Author

Congrats for fixing one more file in Doc/tools/.nitignore, for me a single fixed file is already a great success!

Hold my beer. #107386

serhiy-storchaka added a commit that referenced this pull request Jul 28, 2023
[3.11] gh-107091: Fix some uses of :const: role (GH-107379) (GH-107385)
c343252 
It is for references, not for literals.
(cherry picked from commit 0aa58fa)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
vsajip Awaiting requested review from vsajip vsajip is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL