gh-107446: Fix test_inspect.test_class_with_method_from_other_module under --forever - #107451
Merged
kumaraditya303 merged 5 commits intoAug 3, 2023
Merged
kumaraditya303 merged 5 commits into
kumaraditya303 merged 5 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Eclips4
approved these changes
Jul 30, 2023
Eclips4
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for the fix!
Just FYI, I've found it via running refleak tests with 3:3 option. Probably, it's has the same mechanism of running tests as the --forever parameter.
Sorry, something went wrong.
carljm
reviewed
Aug 2, 2023
Comment thread
Lib/test/test_inspect.py
Outdated
Comment thread
Lib/test/test_inspect.py
Outdated
kumaraditya303
enabled auto-merge (squash)
August 3, 2023 14:36
kumaraditya303
approved these changes
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test creates a temporary directory to store the modules every time it executes. However, with --forever, the test will run more than once. When the old directory got removed, the cached module would lost source. In order to fix this, we can simply remove the module from sys.modules and force the module to be reloaded every time.