FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-106368: Increase test coverage for Argument Clinic by erlend-aasland · Pull Request #107514 · python/cpython · GitHub

/ cpython Public

gh-106368: Increase test coverage for Argument Clinic - #107514

Merged
erlend-aasland merged 6 commits into
python:mainfrom
erlend-aasland:clinic/coverage
Aug 2, 2023
ConversationCommits (6)ChecksFiles changed
Merged

gh-106368: Increase test coverage for Argument Clinic#107514
erlend-aasland merged 6 commits into
python:mainfrom
erlend-aasland:clinic/coverage

Conversation

erlend-aasland commented Jul 31, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

erlend-aasland requested a review from sobolevn July 31, 2023 21:11
bedevere-bot mentioned this pull request Jul 31, 2023
Closed

erlend-aasland commented Jul 31, 2023

Copy link
Copy Markdown
Contributor Author

With this, we're pretty good covered (above 90%). AFAICS, converters, return converters, and most parser code has been tested. Most of what's missing is various error paths.

I suggest we close the linked issue after landing this.

AlexWaygood reviewed Jul 31, 2023
View reviewed changes
Comment thread Lib/test/test_clinic.py Outdated
sobolevn reviewed Jul 31, 2023
View reviewed changes

sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! 👍

Comment thread Lib/test/clinic.test.c Outdated
Comment thread Lib/test/test_clinic.py Outdated
AlexWaygood mentioned this pull request Aug 2, 2023
Merged

This comment was marked as outdated.

Sign in to view
AlexWaygood approved these changes Aug 2, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The .py tests LGTM! Nikita's almost certainly a better reviewer for the functional tests :)

erlend-aasland linked an issue Aug 2, 2023 that may be closed by this pull request
Increase Argument Clinic test coverage #106368
Closed

erlend-aasland commented Aug 2, 2023

Copy link
Copy Markdown
Contributor Author

The .py tests LGTM! Nikita's almost certainly a better reviewer for the functional tests :)

Thanks for the review; Nikita gave a thumbs up for the functional tests earlier, so I'll enable auto-merge 🚀

erlend-aasland enabled auto-merge (squash) August 2, 2023 12:50
erlend-aasland merged commit b9c9a36 into python:main Aug 2, 2023

miss-islington commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b9c9a36c2f2edc11b9c27eb7c5810919d9da9767 3.12

miss-islington commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b9c9a36c2f2edc11b9c27eb7c5810919d9da9767 3.11

erlend-aasland deleted the clinic/coverage branch August 2, 2023 13:36

picnixz commented Sep 14, 2024

Copy link
Copy Markdown
Member

3.11 and 3.12 never got their backports but I'm removing the labels (I'm going through PRs to see if we did not forgot a backport) (not sure if you want to backport this on 3.12)

picnixz removed needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes
sobolevn Awaiting requested review from sobolevn

Assignees

erlend-aasland

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Increase Argument Clinic test coverage

6 participants

Back | FazBrowse Home | New Git URL