FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add some GC stats to Py_STATS by markshannon · Pull Request #107581 · python/cpython · GitHub

/ cpython Public

Add some GC stats to Py_STATS - #107581

Merged
markshannon merged 5 commits into
python:mainfrom
faster-cpython:gc-stats
Aug 4, 2023
ConversationCommits (5)ChecksFiles changed
Merged

Add some GC stats to Py_STATS#107581
markshannon merged 5 commits into
python:mainfrom
faster-cpython:gc-stats

Conversation

markshannon commented Aug 3, 2023

Copy link
Copy Markdown
Member

This partly duplicates the stats from the GC module, but serves a different purpose, as it allows us to gather stats that would be too expensive to gather in a release build.

The stats:
https://github.com/faster-cpython/benchmarking/blob/main/results/bm-20230730-3.13.0a0-8bc0926/bm-20230730-azure-x86_64-faster%252dcpython-gc_stats-3.13.0a0-8bc0926-pystats.md

markshannon requested a review from pablogsal as a code owner August 3, 2023 08:48

pablogsal commented Aug 3, 2023

Copy link
Copy Markdown
Member

I have already a PR open for this:

#100958

I would prefer to complete that one if possible

markshannon commented Aug 3, 2023

Copy link
Copy Markdown
Member Author

@pablogsal
If you want more stats could you use the Py_STATS mechanism?
That way the GC stats can be gathered along with all the other stats.

If you need additional timings, then adding an -X mechanism makes sense.
In that case I don't think that we want stats as the additional overhead will mess up the timings.

markshannon commented Aug 3, 2023

Copy link
Copy Markdown
Member Author

@pablogsal
I'd like to get this merged, as it just adds a few stats using the Py_STATS mechanism, whereas #100958 seems much broader.

There is some overlap between this PR and #100958, but #100958 has been open since January, and I'm worried that we will have no stats at all for months.
I'll be happy to review #100958 once it is mergeable.

As an aside:
Treating objects visited as a proxy for time taken, both your and my stats seem to show similar results.
Gen 2 is the most efficient, followed by gen 1 then gen 3.

pablogsal commented Aug 3, 2023

Copy link
Copy Markdown
Member

Ok let's merge this PR and let's refine the other one 👍

iritkatriel approved these changes Aug 4, 2023
View reviewed changes

iritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

markshannon merged commit 2ba7c7f into python:main Aug 4, 2023
markshannon deleted the gc-stats branch August 6, 2024 10:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

iritkatriel iritkatriel approved these changes
pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL