gh-106368: Increase Argument Clinic test coverage - #107582
Merged
erlend-aasland merged 1 commit intoAug 3, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Add tests for DSL parser state machine and docstring formatting
Copy link
Copy Markdown
Contributor
Author
|
Increases coverage from 91% to 92%. Catches most of the weird branches in the state machine. The remaining branches are hard, if not impossible, to trigger. There are multiple layers of conditions and exception handling; I'd not be surprised if most of the remaining branches are actually unreachable. |
Sorry, something went wrong.
AlexWaygood
approved these changes
Aug 3, 2023
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
The .py tests LGTM! Just one question:
Sorry, something went wrong.
Comment thread
Lib/test/test_clinic.py
erlend-aasland
enabled auto-merge (squash)
August 3, 2023 09:32
Copy link
Copy Markdown
Contributor
Author
|
Thanks for the review! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for DSL parser state machine and docstring formatting