FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-84436: Skip refcounting for known immortals by brandtbucher · Pull Request #107605 · python/cpython · GitHub

/ cpython Public

GH-84436: Skip refcounting for known immortals - #107605

Merged
brandtbucher merged 2 commits into
python:mainfrom
brandtbucher:immortal-increfs
Aug 4, 2023
ConversationCommits (2)ChecksFiles changed
Merged

GH-84436: Skip refcounting for known immortals#107605
brandtbucher merged 2 commits into
python:mainfrom
brandtbucher:immortal-increfs

Conversation

brandtbucher commented Aug 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

These are a few dozen places where we're still attempting to increment the refcounts of known immortal objects.

brandtbucher added performance Performance or resource usage interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Aug 3, 2023
brandtbucher self-assigned this Aug 3, 2023
bedevere-bot mentioned this pull request Aug 3, 2023
Closed
brandtbucher added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Aug 3, 2023

bedevere-bot commented Aug 3, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @brandtbucher for commit 8abbc6a 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

bedevere-bot commented Aug 3, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @brandtbucher for commit 8abbc6a 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Aug 3, 2023
gvanrossum approved these changes Aug 3, 2023
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good change! I'm impressed you found these.

brandtbucher commented Aug 4, 2023

Copy link
Copy Markdown
Member Author

Checked all 17(!) of the failing buildbots, and they're failing for the same reasons on other PRs. So, unrelated to this change.

brandtbucher merged commit 05a824f into python:main Aug 4, 2023
encukou mentioned this pull request Aug 30, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes
kumaraditya303 kumaraditya303 approved these changes
markshannon Awaiting requested review from markshannon markshannon is a code owner
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
willingc Awaiting requested review from willingc willingc is a code owner

Assignees

brandtbucher

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL