[3.12] gh-107609: Fix duplicate module check in Argument Clinic (GH-107610) - #107612
Closed
miss-islington wants to merge 1 commit into
Closed
[3.12] gh-107609: Fix duplicate module check in Argument Clinic (GH-107610)#107612miss-islington wants to merge 1 commit into
miss-islington wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…nGH-107610) Also remove duplicate module def from _testcapi. (cherry picked from commit a443c31) Co-authored-by: Erlend E. Aasland <erlend@python.org>
This was referenced Aug 4, 2023
Copy link
Copy Markdown
Member
|
@erlend-aasland, looks like the CI is failing here, I think because #107551 wasn't backported |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
I'll get to that. Thanks for the heads-up. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
OTOH, I think we should not bother backporting this. It is more of a "cosmetic" bug; it does not change the behaviour of the generator, so it is not a bug-fix. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also remove duplicate module def from _testcapi.
(cherry picked from commit a443c31)
Co-authored-by: Erlend E. Aasland erlend@python.org