FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-107614: Normalise Argument Clinic error messages by erlend-aasland · Pull Request #107615 · python/cpython · GitHub

/ cpython Public

gh-107614: Normalise Argument Clinic error messages - #107615

Merged
erlend-aasland merged 10 commits into
python:mainfrom
erlend-aasland:clinic/normalise-error-messages
Aug 4, 2023
ConversationCommits (10)ChecksFiles changed
Merged

gh-107614: Normalise Argument Clinic error messages#107615
erlend-aasland merged 10 commits into
python:mainfrom
erlend-aasland:clinic/normalise-error-messages

Conversation

erlend-aasland commented Aug 4, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor
  • always wrap the offending line, token, or name in quotes
  • always put the entire error message on one line

pythongh-107614: Normalise Argument Clinic error messages
c66a492 
- always wrap the offending line, token, or name in quotes
- always put the entire error message on one line
bedevere-bot mentioned this pull request Aug 4, 2023
Closed
erlend-aasland mentioned this pull request Aug 4, 2023
Merged

erlend-aasland commented Aug 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Depends on gh-107611 (or the other way around; either way, we'll have conflicts)

erlend-aasland commented Aug 4, 2023
View reviewed changes
Comment thread Lib/test/test_clinic.py
AlexWaygood reviewed Aug 4, 2023
View reviewed changes
Comment thread Lib/test/test_clinic.py
Comment thread Lib/test/test_clinic.py
Comment thread Lib/test/test_clinic.py Outdated
Comment thread Tools/clinic/clinic.py Outdated
Comment thread Tools/clinic/clinic.py Outdated
Comment thread Tools/clinic/clinic.py Outdated
Comment thread Tools/clinic/clinic.py Outdated
AlexWaygood reviewed Aug 4, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Some suggestions to keep line lengths below 90, where reasonable:

Comment thread Tools/clinic/clinic.py Outdated
Comment thread Tools/clinic/clinic.py Outdated
Comment thread Tools/clinic/clinic.py Outdated
Comment thread Tools/clinic/clinic.py Outdated
Comment thread Tools/clinic/clinic.py Outdated
Comment thread Tools/clinic/clinic.py Outdated
Comment thread Tools/clinic/clinic.py Outdated
Comment thread Tools/clinic/clinic.py Outdated
Comment thread Tools/clinic/clinic.py Outdated
Comment thread Tools/clinic/clinic.py Outdated
Apply suggestions from code review
015dea8 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

erlend-aasland commented Aug 4, 2023

Copy link
Copy Markdown
Contributor Author

Some suggestions to keep line lengths below 90, where reasonable:

Thanks; applied!

AlexWaygood reviewed Aug 4, 2023
View reviewed changes
Comment thread Lib/test/test_clinic.py
AlexWaygood reviewed Aug 4, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Outdated
AlexWaygood reviewed Aug 4, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Outdated
AlexWaygood reviewed Aug 4, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Outdated
AlexWaygood approved these changes Aug 4, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Outdated
erlend-aasland and others added 2 commits August 4, 2023 13:23
Final touch
d681648 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Add test for dest clear
882fe9d
AlexWaygood approved these changes Aug 4, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks great, thank you!

erlend-aasland commented Aug 4, 2023

Copy link
Copy Markdown
Contributor Author

Looks great, thank you!

Thanks for the helpful review and suggestions!

erlend-aasland enabled auto-merge (squash) August 4, 2023 11:33
erlend-aasland merged commit ac7605e into python:main Aug 4, 2023
erlend-aasland deleted the clinic/normalise-error-messages branch August 4, 2023 12:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL