FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Docs: upgrade to python-docs-theme 2023.7 by hugovk · Pull Request #107617 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

Docs: upgrade to python-docs-theme 2023.7 - #107617

Merged
hugovk merged 2 commits into
python:mainfrom
hugovk:bump-python-docs-theme
Aug 4, 2023
ConversationCommits (2)ChecksFiles changed
Merged

Docs: upgrade to python-docs-theme 2023.7#107617
hugovk merged 2 commits into
python:mainfrom
hugovk:bump-python-docs-theme

Conversation

hugovk commented Aug 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

The venv used on the docs server persists between deploys, therefore let's pin the theme so we get the version we want:

This means we'll get the dark theme for 3.11 (aka the main https://docs.python.org/3/). We've already had it on https://docs.python.org/3.12/ and https://docs.python.org/3.13/ for a few months.

Let's also bump Sphinx to include the latest 6.x patch release:

(We have another PR to upgrade Sphinx to 7.x, let's handle that separately: #99381)

📚 Documentation preview 📚: https://cpython-previews--107617.org.readthedocs.build/

hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Aug 4, 2023
hugovk mentioned this pull request Aug 4, 2023
Closed
AA-Turner approved these changes Aug 4, 2023
View reviewed changes

AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We could potentially do >=2023.7, but fairly minor.

A

hugovk commented Aug 4, 2023

Copy link
Copy Markdown
Member Author

Good idea, I'll update it to >=2023.7.

hugovk enabled auto-merge (squash) August 4, 2023 14:01
hugovk merged commit 19f32b2 into python:main Aug 4, 2023
hugovk deleted the bump-python-docs-theme branch August 4, 2023 14:16

miss-islington commented Aug 4, 2023

Copy link
Copy Markdown
Contributor

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington commented Aug 4, 2023

Copy link
Copy Markdown
Contributor

Sorry, @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 19f32b24b2e1680ff9929bb64d681397b259c6fb 3.12

miss-islington commented Aug 4, 2023

Copy link
Copy Markdown
Contributor

Sorry, @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 19f32b24b2e1680ff9929bb64d681397b259c6fb 3.11

hugovk added a commit to hugovk/cpython that referenced this pull request Aug 4, 2023
[3.12] Docs: upgrade to python-docs-theme 2023.7 (pythonGH-107617)
f882985 
(cherry picked from commit 19f32b2)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

bedevere-bot commented Aug 4, 2023

Copy link
Copy Markdown

GH-107633 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 4, 2023

bedevere-bot commented Aug 4, 2023

Copy link
Copy Markdown

GH-107634 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 4, 2023
hugovk added a commit to hugovk/cpython that referenced this pull request Aug 4, 2023
[3.11] Docs: upgrade to python-docs-theme 2023.7 (pythonGH-107617)
aed26c6 
(cherry picked from commit 19f32b2)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Yhg1s pushed a commit that referenced this pull request Aug 4, 2023
[3.12] Docs: upgrade to python-docs-theme 2023.7 (GH-107617) (#107633)
28a9849 
(cherry picked from commit 19f32b2)
hugovk added a commit that referenced this pull request Aug 4, 2023
[3.11] Docs: upgrade to python-docs-theme 2023.7 (GH-107617) (#107634)
f978a79 
(cherry picked from commit 19f32b2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AA-Turner AA-Turner approved these changes
hauntsaninja hauntsaninja approved these changes

Assignees

hugovk

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL