FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-106368: Argument clinic: add tests for more failure paths by AlexWaygood · Pull Request #107731 · python/cpython · GitHub

/ cpython Public

gh-106368: Argument clinic: add tests for more failure paths - #107731

Merged
AlexWaygood merged 3 commits into
python:mainfrom
AlexWaygood:clinic-more-coverage
Aug 8, 2023
ConversationCommits (3)ChecksFiles changed
Merged

gh-106368: Argument clinic: add tests for more failure paths#107731
AlexWaygood merged 3 commits into
python:mainfrom
AlexWaygood:clinic-more-coverage

Conversation

AlexWaygood commented Aug 7, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

And fix a minor bug I discovered along the way.

This gets us up to 95% coverage.

bedevere-bot mentioned this pull request Aug 7, 2023
Closed
AlexWaygood commented Aug 7, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py
erlend-aasland reviewed Aug 8, 2023
View reviewed changes
Comment thread Lib/test/test_clinic.py Outdated
erlend-aasland approved these changes Aug 8, 2023
View reviewed changes

erlend-aasland left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good. BTW, can you remove test_parameters_required_after_depr_star (line 1471)? I introduced an equal named, but slightly better test in #95151). Makes sense to bake it into this PR, rather than creating a new PR specifically for that removal.

AlexWaygood commented Aug 8, 2023

Copy link
Copy Markdown
Member Author

Looks good. BTW, can you remove test_parameters_required_after_depr_star (line 1471)? I introduced an equal named, but slightly better test in #95151). Makes sense to bake it into this PR, rather than creating a new PR specifically for that removal.

Hmm, the new test that you added fails if I remove test_parameters_required_after_depr_star on line 1471. The new test method that you added is currently never run, because it is immediately overridden by the old test method later on in the class definition before unittest even tries to run any of the tests.

We really need to start running pyflakes on Tools/clinic/ and test_clinic.py in CI :)

erlend-aasland commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

Well, remove the new test, then 😄

AlexWaygood enabled auto-merge (squash) August 8, 2023 11:15
AlexWaygood merged commit 7c5153d into python:main Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland erlend-aasland approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL