gh-95065: Produce nicer deprecation messages in Argument Clinic - #107808
Merged
erlend-aasland merged 4 commits intoAug 9, 2023
Merged
gh-95065: Produce nicer deprecation messages in Argument Clinic#107808erlend-aasland merged 4 commits into
erlend-aasland merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Author
|
@serhiy-storchaka: this will probably cause merge conflicts with your work on deprecating keyword arguments. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
(the Azure failure is unrelated; flakey test_concurrent_futures test) |
Sorry, something went wrong.
Comment thread
Lib/test/clinic.test.c
Outdated
serhiy-storchaka
approved these changes
Aug 9, 2023
Copy link
Copy Markdown
Member
|
Thank you. Nice change. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks for the review, Serhiy; highly appreciated. |
Sorry, something went wrong.
erlend-aasland
enabled auto-merge (squash)
August 9, 2023 13:00
AlexWaygood
approved these changes
Aug 9, 2023
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Very nice indeed!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.