GH-106485: Create object's dict-values instead of creating __dict__, when we can. - #107843
Merged
markshannon merged 2 commits intoAug 11, 2023
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Skipping news as this is a strictly internal feature. |
Sorry, something went wrong.
iritkatriel
reviewed
Aug 11, 2023
Comment thread
Objects/object.c
Outdated
iritkatriel
approved these changes
Aug 11, 2023
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
markshannon
deleted the
always-allocate-value-for-managed-dict-objects
branch
September 26, 2023 12:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When assigning to an attribute of an object with Py_TPFLAGS_MANAGED_DICT that lacked either a values array or a __dict__,
we currently create a __dict__.
This PR allocates a values array instead.
In an ideal world, we would allocate the values array when we allocate the object.
But that will require better integration of the VM, allocator and GC. So that's for another PR in the future.