gh-107880: Teach Argument Clinic to clone __init__ and __new__ methods - #107885
Merged
erlend-aasland merged 4 commits intoAug 13, 2023
Merged
erlend-aasland merged 4 commits into
erlend-aasland merged 4 commits into
Conversation
This comment was marked as outdated.
Copy link
Copy Markdown
Contributor
Author
|
We should also check that it's possible to clone T1.__init__ = T2.__init__ (ditto for __new__), and also T1.meth = T2.__init__. |
Sorry, something went wrong.
AlexWaygood
approved these changes
Aug 13, 2023
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This was referenced Aug 15, 2023
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this pull request
Aug 15, 2023
pythongh-107885 taught Argument Clinic to clone to __init__ and __new__ methods, but it did not validate the requirements of those special methods.
erlend-aasland
added a commit
that referenced
this pull request
Aug 15, 2023
iritkatriel
pushed a commit
to iritkatriel/cpython
that referenced
this pull request
Aug 16, 2023
…ython#107974) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.