gh-106797: Remove warning logs from Python/generated_cases.c.h and executor_cases.c.h - #107889
Merged
corona10 merged 1 commit intoAug 12, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Compiler warn logs from PGO build Python/generated_cases.c.h:3597:37: warning: code will never be executed [-Wunreachable-code]
stack_pointer[-1 - (0 ? 1 : 0)] = attr;
^
Python/generated_cases.c.h:3597:33: note: silence by adding parentheses to mark code as explicitly dead
stack_pointer[-1 - (0 ? 1 : 0)] = attr;
^
/* DISABLES CODE */ ( )
Python/generated_cases.c.h:3577:37: warning: code will never be executed [-Wunreachable-code]
stack_pointer[-1 - (0 ? 1 : 0)] = attr;
^
Python/generated_cases.c.h:3577:33: note: silence by adding parentheses to mark code as explicitly dead
stack_pointer[-1 - (0 ? 1 : 0)] = attr;
^
/* DISABLES CODE */ ( )
Python/generated_cases.c.h:2254:37: warning: code will never be executed [-Wunreachable-code]
stack_pointer[-1 - (0 ? 1 : 0)] = attr;
^
Python/generated_cases.c.h:2254:33: note: silence by adding parentheses to mark code as explicitly dead
stack_pointer[-1 - (0 ? 1 : 0)] = attr;
^
/* DISABLES CODE */ ( )
In file included from Python/executor.c:84:
Python/executor_cases.c.h:1516:37: warning: code will never be executed [-Wunreachable-code]
stack_pointer[-1 - (0 ? 1 : 0)] = attr;
^
Python/executor_cases.c.h:1516:33: note: silence by adding parentheses to mark code as explicitly dead
stack_pointer[-1 - (0 ? 1 : 0)] = attr;
^
/* DISABLES CODE */ ( )
|
Sorry, something went wrong.
gvanrossum
approved these changes
Aug 12, 2023
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was detected during the PyCon KR sprint from the mentee's compiler.