FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-107877: Update logging levels reference table with usage criteria. by vsajip · Pull Request #107894 · python/cpython · GitHub

/ cpython Public

gh-107877: Update logging levels reference table with usage criteria. - #107894

Merged
vsajip merged 3 commits into
python:mainfrom
vsajip:fix-107877
Aug 13, 2023
ConversationCommits (3)ChecksFiles changed
Merged

gh-107877: Update logging levels reference table with usage criteria.#107894
vsajip merged 3 commits into
python:mainfrom
vsajip:fix-107877

Conversation

vsajip commented Aug 12, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

vsajip added docs Documentation in the Doc dir skip news labels Aug 12, 2023
vsajip requested a review from CAM-Gerlach August 12, 2023 14:33
vsajip self-assigned this Aug 12, 2023
bedevere-bot mentioned this pull request Aug 12, 2023
Closed
AlexWaygood reviewed Aug 12, 2023
View reviewed changes
Comment thread Doc/library/logging.rst

AlexWaygood Aug 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You could consider converting the table into a list-table, like we use in the typing docs here:

cpython/Doc/library/typing.rst

Line 3693 in 2e1f688

.. list-table::

It might make it easier to maintain it

vsajip Aug 12, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the suggestion - perhaps not worth changing it again now for this specific instance, but I'll bear in mind when creating tables in future!

AlexWaygood reviewed Aug 12, 2023
View reviewed changes
Comment thread Doc/library/logging.rst Outdated
Comment thread Doc/library/logging.rst Outdated
Comment thread Doc/library/logging.rst Outdated
Comment thread Doc/library/logging.rst Outdated
Apply suggestions from code review
2fecc7f 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
vsajip removed the request for review from CAM-Gerlach August 13, 2023 12:15
AlexWaygood approved these changes Aug 13, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks!

vsajip merged commit cc2cf85 into python:main Aug 13, 2023
vsajip deleted the fix-107877 branch August 13, 2023 13:19
vsajip added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Aug 13, 2023

miss-islington commented Aug 13, 2023

Copy link
Copy Markdown
Contributor

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented Aug 13, 2023

Copy link
Copy Markdown
Contributor

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

bedevere-bot commented Aug 13, 2023

Copy link
Copy Markdown

GH-107921 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 13, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 13, 2023
pythongh-107877: Update logging levels reference table with usage cri…
6ee9c29 
…teria. (pythonGH-107894)

(cherry picked from commit cc2cf85)

Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

bedevere-bot commented Aug 13, 2023

Copy link
Copy Markdown

GH-107922 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 13, 2023
pythongh-107877: Update logging levels reference table with usage cri…
7377f9b 
…teria. (pythonGH-107894)

(cherry picked from commit cc2cf85)

Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 13, 2023
vsajip pushed a commit that referenced this pull request Aug 13, 2023
[3.11] gh-107877: Update logging levels reference table with usage cr…
e2420c5 
…iteria. (GH-107894) (GH-107921)

gh-107877: Update logging levels reference table with usage criteria. (GH-107894)
(cherry picked from commit cc2cf85)
Yhg1s pushed a commit that referenced this pull request Aug 14, 2023
[3.12] gh-107877: Update logging levels reference table with usage cr…
ba8ab4e 
…iteria. (GH-107894) (#107922)

gh-107877: Update logging levels reference table with usage criteria. (GH-107894)
(cherry picked from commit cc2cf85)

Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes

Assignees

vsajip

Labels

docs Documentation in the Doc dir skip news

Projects

Logging issues 🪵
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL