gh-105481: reduce repetition in opcode metadata generation code - #107942
Merged
iritkatriel merged 2 commits intoAug 14, 2023
Merged
gh-105481: reduce repetition in opcode metadata generation code#107942iritkatriel merged 2 commits into
iritkatriel merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
gvanrossum
approved these changes
Aug 14, 2023
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Optional suggestion.
Sorry, something went wrong.
Comment thread
Tools/cases_generator/generate_cases.py
Outdated
| with self.metadata_item( | ||
| f"int _PyOpcode_num_{direction}(int opcode, int oparg, bool jump)", "", "" | ||
| ): | ||
| self.out.emit(" switch(opcode) {") |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
You could use ‘with self.out.block()’ and indent() here instead of adding spaces to the statements.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will simplify adding more stuff to the metadata.