FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-105481: generate op IDs from bytecode.c instead of hard coding them in opcode.py by iritkatriel · Pull Request #107971 · python/cpython · GitHub

/ cpython Public

gh-105481: generate op IDs from bytecode.c instead of hard coding them in opcode.py - #107971

Merged
iritkatriel merged 18 commits into
python:mainfrom
iritkatriel:deopt
Aug 16, 2023
ConversationCommits (18)ChecksFiles changed
Merged

gh-105481: generate op IDs from bytecode.c instead of hard coding them in opcode.py#107971
iritkatriel merged 18 commits into
python:mainfrom
iritkatriel:deopt

Conversation

iritkatriel commented Aug 15, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request Aug 15, 2023
Closed
iritkatriel marked this pull request as draft August 15, 2023 12:01
Eclips4 added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Aug 15, 2023
ericsnowcurrently approved these changes Aug 15, 2023
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Mostly LGTM. I've left a couple comments where there might be something further to be done.

(I'm approving under the assumption the comments will be resolved first, one way or another.)

Comment thread Include/opcode_ids.h
Comment thread Lib/opcode.py

iritkatriel commented Aug 15, 2023

Copy link
Copy Markdown
Member Author

Mostly LGTM. I've left a couple comments where there might be something further to be done.

Thanks. A couple of tests for tracing/instrumentation are failing, I'm still debugging that.

brettcannon removed their request for review August 15, 2023 21:57
iritkatriel marked this pull request as ready for review August 16, 2023 16:17
iritkatriel requested a review from a team as a code owner August 16, 2023 16:17
iritkatriel requested a review from gvanrossum August 16, 2023 16:42
gvanrossum approved these changes Aug 16, 2023
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The revolution! It's almost here!!

A few nits but no need to wait for a re-review.

Comment thread Lib/test/test_dis.py
@@ -1617,197 +1616,197 @@ def _prepare_test_cases():
Instruction = dis.Instruction

expected_opinfo_outer = [

gvanrossum Aug 16, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This test is just preposterous. Let's commit to doing this in a different way in a future PR.

iritkatriel Aug 16, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@markshannon loves to hate this test too.

Comment thread Tools/build/deepfreeze.py
Comment thread Makefile.pre.in
Comment thread Tools/cases_generator/generate_cases.py Outdated
Comment thread Tools/cases_generator/generate_cases.py Outdated
iritkatriel enabled auto-merge (squash) August 16, 2023 22:13
iritkatriel merged commit 665a439 into python:main Aug 16, 2023
markshannon mentioned this pull request Sep 11, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericsnowcurrently ericsnowcurrently approved these changes
gvanrossum gvanrossum approved these changes
ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
warsaw Awaiting requested review from warsaw warsaw is a code owner
markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL