FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-108278: Deprecate passing the three first params as keyword args for sqlite3 UDF creation APIs by erlend-aasland · Pull Request #108281 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-108278: Deprecate passing the three first params as keyword args for sqlite3 UDF creation APIs - #108281

Merged
erlend-aasland merged 10 commits into
python:mainfrom
erlend-aasland:sqlite/cleanup-connection-apis
Aug 28, 2023
ConversationCommits (10)ChecksFiles changed
Merged

gh-108278: Deprecate passing the three first params as keyword args for sqlite3 UDF creation APIs#108281
erlend-aasland merged 10 commits into
python:mainfrom
erlend-aasland:sqlite/cleanup-connection-apis

Conversation

erlend-aasland commented Aug 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Deprecate passing name, number of arguments, and the callable as keyword
arguments, for the following sqlite3.Connection APIs:

  • create_function(name, nargs, callable, ...)
  • create_aggregate(name, nargs, callable)

The affected parameters will become positional-only in Python 3.15.

📚 Documentation preview 📚: https://cpython-previews--108281.org.readthedocs.build/

pythongh-108278: Clean up some sqlite3 connection APIs
4f89b4c 
Deprecate passing name, number of arguments, and the callable as keyword
arguments, for the following sqlite3.Connection APIs:

- create_function(name, nargs, callable, ...)
- create_aggregate(name, nargs, callable)

Deprecate passing the callback as a keyword argument, for the following
sqlite3.Connection APIs:

- set_authorizer(callback)
- set_progress_handler(callback, n)
- set_trace_callback(callback)

The affected parameters will become positional-only in Python 3.15.
bedevere-bot mentioned this pull request Aug 22, 2023
Closed
erlend-aasland changed the title gh-108278: Clean up some sqlite3 connection APIs gh-108278: Clean up sqlite3.Connection APIs Aug 22, 2023
erlend-aasland marked this pull request as ready for review August 22, 2023 20:05
erlend-aasland changed the title gh-108278: Clean up sqlite3.Connection APIs gh-108278: Deprecate passing the three first params as keyword args for sqlite3 UDF creation APIs Aug 23, 2023

erlend-aasland commented Aug 23, 2023

Copy link
Copy Markdown
Contributor Author

I updated the PR to only affect UDF creation APIs.

erlend-aasland commented Aug 23, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Outdated

erlend-aasland commented Aug 24, 2023

Copy link
Copy Markdown
Contributor Author

I'd like to land this; are you ok with the change, @serhiy-storchaka?

erlend-aasland commented Aug 28, 2023

Copy link
Copy Markdown
Contributor Author

I'm landing this. It is for main only, so we have until 3.13 feature freeze (~May 2024) to adjust things or even revert.

serhiy-storchaka approved these changes Aug 28, 2023
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, but please get an approval of yet one core developer. Has this change been discussed with a wider audience?

Comment thread Lib/test/test_sqlite3/test_userfunctions.py Outdated

erlend-aasland commented Aug 28, 2023

Copy link
Copy Markdown
Contributor Author

LGTM, but please get an approval of yet one core developer. Has this change been discussed with a wider audience?

I posted a topic on Discourse. Brett and Berker left a "heart" reaction; I did not get any discouragements. Since Berker also is a code owner for the sqlite3 code, I count that as fairly strong support.

serhiy-storchaka commented Aug 28, 2023

Copy link
Copy Markdown
Member

Well, then go ahead!

erlend-aasland enabled auto-merge (squash) August 28, 2023 13:08
erlend-aasland merged commit 4116592 into python:main Aug 28, 2023

bedevere-bot commented Aug 28, 2023

Copy link
Copy Markdown

There's a new commit after the PR has been approved.

@serhiy-storchaka: please review the changes made to this pull request.

vstinner pushed a commit to vstinner/cpython that referenced this pull request Aug 28, 2023
pythongh-108278: Deprecate passing the three first params as keyword …
e4ede8e 
…args for sqlite3 UDF creation APIs (python#108281)

Deprecate passing name, number of arguments, and the callable as keyword
arguments, for the following sqlite3.Connection APIs:

- create_function(name, nargs, callable, ...)
- create_aggregate(name, nargs, callable)

The affected parameters will become positional-only in Python 3.15.
erlend-aasland deleted the sqlite/cleanup-connection-apis branch August 28, 2023 19:22
erlend-aasland mentioned this pull request Aug 29, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

berkerpeksag Awaiting requested review from berkerpeksag
serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL