Repository navigation
gh-107149: Rename _PyUnstable_GetUnaryIntrinsicName() function - #108441
Merged
vstinner merged 1 commit intoAug 28, 2023
Merged
vstinner merged 1 commit into
vstinner merged 1 commit into
Conversation
* Rename _PyUnstable_GetUnaryIntrinsicName() to PyUnstable_GetUnaryIntrinsicName() * Rename _PyUnstable_GetBinaryIntrinsicName() to PyUnstable_GetBinaryIntrinsicName().
Copy link
Copy Markdown
Member
Author
|
_PyUnstable_GetUnaryIntrinsicName() was added by @iritkatriel in commit 9c81fc2. Same question than issue #107149 and PR #108440: either the API is made public in the unstable API and so PyUnstable_ prefix is correct. Or the function should be made private, but in this case, it should be moved to the internal C API, not be exported, and drop its PyUnstable prefix. |
Sorry, something went wrong.
vstinner
marked this pull request as draft
August 24, 2023 17:35
vstinner
marked this pull request as ready for review
August 28, 2023 23:41
Copy link
Copy Markdown
Member
Author
|
According to @iritkatriel, the _Py prefix was not deliberate: #107149 (comment) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Note: this API is new in Python 3.13, Python 3.12 is not affected. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.