Repository navigation
gh-108364: Simplify quoting values and identifiers in sqlite3's iterdump() - #108472
Merged
erlend-aasland merged 3 commits intoAug 25, 2023
Merged
erlend-aasland merged 3 commits into
erlend-aasland merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
felixxm
commented
Aug 25, 2023
Comment thread
Lib/sqlite3/dump.py
Outdated
Copy link
Copy Markdown
Contributor
|
This is a nice cleanup. I think we should add this as a separate PR, instead of as a part of #108340. |
Sorry, something went wrong.
felixxm
force-pushed
the
sqlite-dump-readable
branch
from
333c0f5 to
2423154
Compare
August 25, 2023 09:42
Copy link
Copy Markdown
Contributor
Sounds good to me. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Seems main was recently broken by #107988; we'll have to wait for that issue to be resolved before landing. |
Sorry, something went wrong.
erlend-aasland
approved these changes
Aug 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup for #108340.