FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Docs: Resolve Sphinx warnings in dis.rst by erlend-aasland · Pull Request #108476 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

Docs: Resolve Sphinx warnings in dis.rst - #108476

Merged
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:docs/dis.rst
Aug 25, 2023
ConversationCommits (2)ChecksFiles changed
Merged

Docs: Resolve Sphinx warnings in dis.rst#108476
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:docs/dis.rst

Conversation

erlend-aasland commented Aug 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Link to the code objects reference
  • Suppress link to deliberately undocumented builtins.__build_class__
  • Suppress links for example methods

📚 Documentation preview 📚: https://cpython-previews--108476.org.readthedocs.build/

Docs: Resolve Sphinx warnings in dis.rst
b08ed39 
- Link to the code objects reference
- Suppress link to deliberately undocumented builtins.__build_class__
- Suppress links for example methods
AlexWaygood approved these changes Aug 25, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

erlend-aasland commented Aug 25, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the review, Alex!

erlend-aasland merged commit cb11842 into python:main Aug 25, 2023

This comment was marked as outdated.

Sign in to view
erlend-aasland deleted the docs/dis.rst branch August 25, 2023 11:28

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

serhiy-storchaka commented Aug 25, 2023

Copy link
Copy Markdown
Member

LGTM.

sobolevn mentioned this pull request Aug 25, 2023
Closed
erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes and removed needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Aug 27, 2023

miss-islington commented Aug 27, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented Aug 27, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington commented Aug 27, 2023

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker cb1184280b3fb369a07abb4153aa36829cf1df9b 3.11

bedevere-bot commented Aug 27, 2023

Copy link
Copy Markdown

GH-108546 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 27, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 27, 2023
Docs: Resolve Sphinx warnings in dis.rst (pythonGH-108476)
3a51497 
- Link to the code objects reference
- Suppress link to deliberately undocumented builtins.__build_class__
- Suppress links for example methods
(cherry picked from commit cb11842)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland removed the needs backport to 3.11 only security fixes label Aug 27, 2023

erlend-aasland commented Aug 27, 2023

Copy link
Copy Markdown
Contributor Author

dis.rst looks a lot more different in 3.11 than in 3.12; I'm not sure that backport is worth it.

Yhg1s pushed a commit that referenced this pull request Aug 27, 2023
[3.12] Docs: Resolve Sphinx warnings in dis.rst (GH-108476) (#108546)
311fd96 
Docs: Resolve Sphinx warnings in dis.rst (GH-108476)

- Link to the code objects reference
- Suppress link to deliberately undocumented builtins.__build_class__
- Suppress links for example methods
(cherry picked from commit cb11842)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

erlend-aasland

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL