FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "gh-107265: Ensure _PyCode_Quicken does not handle ENTER_EXECU… by corona10 · Pull Request #108485 · python/cpython · GitHub

/ cpython Public

Revert "gh-107265: Ensure _PyCode_Quicken does not handle ENTER_EXECU… - #108485

Merged
gvanrossum merged 1 commit into
python:mainfrom
corona10:gh-107265-_PyCode_Quicken-revert
Aug 25, 2023
Merged

Revert "gh-107265: Ensure _PyCode_Quicken does not handle ENTER_EXECU…#108485
gvanrossum merged 1 commit into
python:mainfrom
corona10:gh-107265-_PyCode_Quicken-revert

Conversation

corona10 commented Aug 25, 2023
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Member Author
(.oss) ➜  cpython git:(gh-107265-_PyCode_Quicken-revert) ✗ ./python.exe -Xuops -m test test_sys
Raised RLIMIT_NOFILE: 256 -> 1024
0:00:00 load avg: 7.68 Run tests sequentially
0:00:00 load avg: 7.68 [1/1] test_sys
Assertion failed: (opcode != ENTER_EXECUTOR), function _PyCode_Quicken, file specialize.c, line 304.
Fatal Python error: Aborted

Current thread 0x0000000104dbc580 (most recent call first):
  <no Python frame>

Extension modules: _xxsubinterpreters, _xxinterpchannels, _testinternalcapi (total: 3)
[1]    20667 abort      ./python.exe -Xuops -m test test_sys

gvanrossum enabled auto-merge (squash) August 25, 2023 14:58
gvanrossum merged commit 66b4d9c into python:main Aug 25, 2023
corona10 deleted the gh-107265-_PyCode_Quicken-revert branch August 25, 2023 15:24

Copy link
Copy Markdown
Member Author

@gvanrossum
Even if we revert this assertion, I still think that decoding instruction to JUMP_BACKWARD is not needed since it's only counter-initialization.

instructions[i + 1].cache = adaptive_counter_warmup();

static inline uint16_t
adaptive_counter_bits(int value, int backoff) {
return (value << ADAPTIVE_BACKOFF_BITS) |
(backoff & ((1<<ADAPTIVE_BACKOFF_BITS)-1));
}

We are in the same line, or do you have different ideas?

Copy link
Copy Markdown
Member

See #108488

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL