FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-108202: Combine documentation of ``calendar`` constants by AA-Turner · Pull Request #108492 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

GH-108202: Combine documentation of calendar constants - #108492

Merged
hugovk merged 4 commits into
python:mainfrom
AA-Turner:calendar/enums
Aug 28, 2023
ConversationCommits (4)ChecksFiles changed
Merged

GH-108202: Combine documentation of calendar constants#108492
hugovk merged 4 commits into
python:mainfrom
AA-Turner:calendar/enums

Conversation

AA-Turner commented Aug 25, 2023 •
edited by hugovk
Loading

Copy link
Copy Markdown
Member

The weekday constants were already defined in the "data attributes" section of the docs, this moves the month constants to match. This also benefits the reader of the calendar documentation, as the first API documented is now calendar.Calendar, rather than two enumerations.

📚 Documentation preview 📚: https://cpython-previews--108492.org.readthedocs.build/en/108492/library/calendar.html

AA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.12 only security fixes labels Aug 25, 2023
bedevere-bot mentioned this pull request Aug 25, 2023
Open

hugovk commented Aug 26, 2023

Copy link
Copy Markdown
Member

Thanks, shall we also group the day things together, and the month things together?

AA-Turner commented Aug 26, 2023

Copy link
Copy Markdown
Member Author

Good idea, done.

A

hugovk approved these changes Aug 26, 2023
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

hugovk merged commit 5d936b6 into python:main Aug 28, 2023

miss-islington commented Aug 28, 2023

Copy link
Copy Markdown
Contributor

Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington commented Aug 28, 2023

Copy link
Copy Markdown
Contributor

Sorry, @AA-Turner and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5d936b64796261373429c86cdf90b1d8d8acefba 3.12

AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Aug 28, 2023
[3.12] pythonGH-108202: Combine documentation of calendar constan…
a15a3bf 
…ts (pythonGH-108492).

(cherry picked from commit 5d936b6)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

AA-Turner commented Aug 28, 2023

Copy link
Copy Markdown
Member Author

Sorry for the delay, backport now opened.

A

bedevere-bot commented Aug 28, 2023

Copy link
Copy Markdown

GH-108579 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 28, 2023
Yhg1s pushed a commit that referenced this pull request Aug 28, 2023
[3.12] GH-108202: Combine documentation of calendar constants (GH…
7c7b2bf 
…-108492) (#108579)

[3.12] GH-108202: Combine documentation of ``calendar`` constants (GH-108492).
(cherry picked from commit 5d936b6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes
erlend-aasland erlend-aasland approved these changes

Assignees

hugovk

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL