FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-108494: AC supports pos-only args in limited C API by vstinner · Pull Request #108498 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-108494: AC supports pos-only args in limited C API - #108498

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:ac_pos_limited
Aug 25, 2023
ConversationCommits (1)ChecksFiles changed
Merged

gh-108494: AC supports pos-only args in limited C API#108498
vstinner merged 1 commit into
python:mainfrom
vstinner:ac_pos_limited

Conversation

vstinner commented Aug 25, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

AC now checks for "#define Py_LIMITED_API" pattern to use the limited C API.

bedevere-bot mentioned this pull request Aug 25, 2023
Closed
pythongh-108494: AC supports pos-only args in limited C API
c38deb5 
AC now checks for "#define Py_LIMITED_API" pattern to use the limited
C API.
vstinner merged commit 86bc9e3 into python:main Aug 25, 2023
vstinner deleted the ac_pos_limited branch August 25, 2023 22:39
serhiy-storchaka reviewed Aug 26, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py
{parse_arguments}))
goto exit;
""", indent=4)]
argname_fmt = 'args[%d]'

serhiy-storchaka Aug 26, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It is not correct. In best case it is unused.

vstinner Aug 26, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Since AC and parsing arguments are complex, I propose to implement incrementally the limited C API. I'm not sure that I get your comment, when is it unused? Do you want to propose a fix?

AlexWaygood reviewed Aug 28, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@vstinner, would you be able to add some documentation for this change to https://docs.python.org/3/howto/clinic.html? It would be useful information for users of Argument Clinic to know that they can generate code that only uses the limited C API by adding #define Py_LIMITED_API to a file

vstinner commented Aug 28, 2023

Copy link
Copy Markdown
Member Author

@vstinner, would you be able to add some documentation for this change to https://docs.python.org/3/howto/clinic.html? It would be useful information for users of Argument Clinic to know that they can generate code that only uses the limited C API by adding #define Py_LIMITED_API to a file

I wrote PR #108584 to document the Limited C API feature.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka left review comments
AlexWaygood AlexWaygood left review comments
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL