FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-85283: _statistics uses the limited C API by vstinner · Pull Request #108500 · python/cpython · GitHub

Repository navigation

gh-85283: _statistics uses the limited C API - #108500

Closed
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:limit_statistics
Closed

vstinner wants to merge 1 commit into
python:mainfrom
vstinner:limit_statistics

Conversation

vstinner commented Aug 25, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Argument Clinic supports positional-only arguments for the limited C API.

Argument Clinic supports positional-only arguments for the limited C
API.

Copy link
Copy Markdown
Member Author

With this change, _statistics._normal_dist_inv_cdf() uses less efficient code to parse its arguments:

  • Use METH_VARARGS calling convention (pass arguments as a tuple), instead of METH_FASTCALL (no Python object needed to pass arguments)
  • Use PyArg_ParseTuple() to parse arguments with the "ddd:_normal_dist_inv_cdf" string. PyArg_ParseTuple() has to parse the format string. Instead of using inlined code _PyArg_CheckPositional(), PyFloat_CheckExact() / PyFloat_AsDouble() and PyFloat_AS_DOUBLE().

Copy link
Copy Markdown
Member Author

Micro-benchmark on Linux with CPU isolation, Python built with -O3 (without LTO, without PGO):

$ python -m pyperf compare_to ref.json limited.json 
Mean +- std dev: [ref] 88.6 ns +- 1.5 ns -> [limited] 160 ns +- 1 ns: 1.81x slower

Code:

import _statistics
import pyperf

p = 0.5
mu = 0.0
sigma = 1.0

runner = pyperf.Runner()
runner.bench_func('inv_cdf', _statistics._normal_dist_inv_cdf, p, mu, sigma)

Copy link
Copy Markdown
Member Author

I'm not sure if the _statistics is a good candidate for this work on converting stdlib extensions to the limited C API. The Lib/statistics.py module has a pure Python implementation, and the C code is there for optimization. So I would expect best performance for that. Moreover, the function is quite fast, around 100 ns, so the cost of argument parsing is significant.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL