Repository navigation
gh-108494: Build _testclinic_limited on Windows - #108589
Merged
vstinner merged 1 commit intoAug 28, 2023
Merged
vstinner merged 1 commit into
vstinner merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
vstinner
force-pushed
the
ac_build_test_limited_win
branch
from
46c8d54 to
4c79ccb
Compare
August 28, 2023 23:20
vstinner
marked this pull request as ready for review
August 28, 2023 23:21
Add _testclinic_limited project to the Visual Studio solution: * In PCbuild/, copy _asyncio.vcxproj to _testclinic_limited.vcxproj, replace RootNamespace with "_testclinic_limited". * In Visual Stuido, open PCbuild\pcbuild.sln, add the existing "_testclinic_limited" project to the solution. * Add a dependency from "python" project to "_testclinic_limited" project. * Save and exit VS. * Add "_testclinic_limited" to <TestModules Include="..."> in PCbuild\pcbuild.proj.
vstinner
force-pushed
the
ac_build_test_limited_win
branch
from
4c79ccb to
07d21ec
Compare
August 28, 2023 23:26
Copy link
Copy Markdown
Member
Author
|
The _testclinic_limited is now build as expected on Windows. Logs of the Windows x64 GHA CI: _testclinic_limited.c
Creating library D:\a\cpython\cpython\PCbuild\amd64\_testclinic_limited_d.lib and object D:\a\cpython\cpython\PCbuild\amd64\_testclinic_limited_d.exp
_testclinic_limited.vcxproj -> D:\a\cpython\cpython\PCbuild\amd64\_testclinic_limited_d.pyd
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add _testclinic_limited project to the Visual Studio solution:
replace RootNamespace with "_testclinic_limited".
"_testclinic_limited" project to the solution.
project.
in PCbuild\pcbuild.proj.