FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-106320: Remove private _Py_Identifier API by vstinner · Pull Request #108593 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-106320: Remove private _Py_Identifier API - #108593

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:pycore_identifier
Aug 29, 2023
ConversationCommits (1)ChecksFiles changed
Merged

gh-106320: Remove private _Py_Identifier API#108593
vstinner merged 1 commit into
python:mainfrom
vstinner:pycore_identifier

Conversation

vstinner commented Aug 28, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Remove the private _Py_Identifier type and related private functions from the public C API:

  • _PyObject_GetAttrId()
  • _PyObject_LookupSpecialId()
  • _PyObject_SetAttrId()
  • _PyType_LookupId()
  • _Py_IDENTIFIER()
  • _Py_static_string()
  • _Py_static_string_init()

Move them to the internal C API: add a new pycore_identifier.h header file. No longer export these functions.

vstinner requested a review from a team as a code owner August 28, 2023 23:59
bedevere-bot mentioned this pull request Aug 28, 2023
Closed

vstinner commented Aug 28, 2023

Copy link
Copy Markdown
Member Author

Related discussion: https://discuss.python.org/t/c-api-how-much-private-is-the-private-py-identifier-api/29190

pythongh-106320: Remove private _Py_Identifier API
7ccbf0b 
Remove the private _Py_Identifier type and related private functions
from the public C API:

* _PyObject_GetAttrId()
* _PyObject_LookupSpecialId()
* _PyObject_SetAttrId()
* _PyType_LookupId()
* _Py_IDENTIFIER()
* _Py_static_string()
* _Py_static_string_init()

Move them to the internal C API: add a new pycore_identifier.h header
file. No longer export these functions.
vstinner merged commit 4fb96a1 into python:main Aug 29, 2023
vstinner deleted the pycore_identifier branch August 29, 2023 00:29
osandov mentioned this pull request Oct 23, 2023
Closed

osandov commented Oct 23, 2023

Copy link
Copy Markdown
Contributor

Is there a recommendation for what to use instead? I read the discussion linked, but it didn't seem like there was a conclusion on the replacement.

vstinner commented Oct 27, 2023

Copy link
Copy Markdown
Member Author

Is there a recommendation for what to use instead? I read the discussion linked, but it didn't seem like there was a conclusion on the replacement.

I'm worried about these APIs :-( No consensus was found on a migration plan to move away from this private API. Maybe we should consider adding back the private API for now until a clear consensus is found.

This was referenced Oct 30, 2023
Closed
Closed

vstinner commented Oct 30, 2023

Copy link
Copy Markdown
Member Author

@osandov:

Is there a recommendation for what to use instead? I read the discussion linked, but it didn't seem like there was a conclusion on the replacement.

I created #111484

JukkaL mentioned this pull request Oct 14, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL