gh-106320: Remove private _PyLong_New() function - #108604
Merged
vstinner merged 1 commit intoAug 29, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Move the following private API to the internal C API (pycore_long.h): * _PyLong_Copy() * _PyLong_FromDigits() * _PyLong_New() No longer export most of these functions.
Copy link
Copy Markdown
Member
|
@vstinner, we use _PyLong_New() in the gmpy2, e.g. in the GMPy_PyLong_From_MPZ() method. What's now the intended replacement for this private API? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Another user is the sage: $ git grep _PyLong_N src/sage/libs/gmp/pylong.pyx:from cpython.longintrepr cimport _PyLong_New, py_long, digit, PyLong_SHIFT src/sage/libs/gmp/pylong.pyx: L = _PyLong_New(pylong_size) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Would you mind to open a separated issue describing how you use _PyLong_New() and which API do you need? _PyLong_New() changed a lot in Python 3.12: see also issue #111140. |
Sorry, something went wrong.
skirpichev
added a commit
to skirpichev/cpython
that referenced
this pull request
Oct 28, 2023
This partially reverts python#108604.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the following private API to the internal C API (pycore_long.h):
No longer export most of these functions.