gh-110489: Optimise math.ceil for known exact float by hauntsaninja · Pull Request #108801 · python/cpython · GitHub

This matches a similar optimisation done by rhettinger for math.floor in #21072

Before:

λ ./python.exe -m timeit -r 11 -s 'from math import ceil' -s 'x=3.14' 'ceil(x)'
20000000 loops, best of 11: 13.3 nsec per loop
λ ./python.exe -m timeit -r 11 -s 'from math import ceil' -s 'x=0.0' 'ceil(x)'
20000000 loops, best of 11: 13.3 nsec per loop
λ ./python.exe -m timeit -r 11 -s 'from math import ceil' -s 'x=-3.14E32' 'ceil(x)'
10000000 loops, best of 11: 35.3 nsec per loop
λ ./python.exe -m timeit -r 11 -s 'from math import ceil' -s 'x=-323452345.14' 'ceil(x)'
10000000 loops, best of 11: 21.8 nsec per loop

After:

λ ./python.exe -m timeit -r 11 -s 'from math import ceil' -s 'x=3.14' 'ceil(x)'
20000000 loops, best of 11: 11.8 nsec per loop
λ ./python.exe -m timeit -r 11 -s 'from math import ceil' -s 'x=0.0' 'ceil(x)'
20000000 loops, best of 11: 11.7 nsec per loop
λ ./python.exe -m timeit -r 11 -s 'from math import ceil' -s 'x=-3.14E32' 'ceil(x)'
10000000 loops, best of 11: 32.7 nsec per loop
λ ./python.exe -m timeit -r 11 -s 'from math import ceil' -s 'x=-323452345.14' 'ceil(x)'
10000000 loops, best of 11: 20.1 nsec per loop

Issue: Optimise math.ceil for known exact float #110489

This will be partially covered by tests.

After merging #102523 this should be fixed.

Maybe we should follow to the PEP 7 here?

This matches a similar optimisation done for math.floor in python#21072 Before: ``` λ ./python.exe -m timeit -r 11 -s 'from math import ceil' -s 'x=3.14' 'ceil(x)' 20000000 loops, best of 11: 13.3 nsec per loop λ ./python.exe -m timeit -r 11 -s 'from math import ceil' -s 'x=0.0' 'ceil(x)' 20000000 loops, best of 11: 13.3 nsec per loop λ ./python.exe -m timeit -r 11 -s 'from math import ceil' -s 'x=-3.14E32' 'ceil(x)' 10000000 loops, best of 11: 35.3 nsec per loop λ ./python.exe -m timeit -r 11 -s 'from math import ceil' -s 'x=-323452345.14' 'ceil(x)' 10000000 loops, best of 11: 21.8 nsec per loop ``` After: ``` λ ./python.exe -m timeit -r 11 -s 'from math import ceil' -s 'x=3.14' 'ceil(x)' 20000000 loops, best of 11: 11.8 nsec per loop λ ./python.exe -m timeit -r 11 -s 'from math import ceil' -s 'x=0.0' 'ceil(x)' 20000000 loops, best of 11: 11.7 nsec per loop λ ./python.exe -m timeit -r 11 -s 'from math import ceil' -s 'x=-3.14E32' 'ceil(x)' 10000000 loops, best of 11: 32.7 nsec per loop λ ./python.exe -m timeit -r 11 -s 'from math import ceil' -s 'x=-323452345.14' 'ceil(x)' 10000000 loops, best of 11: 20.1 nsec per loop ```

Thanks for the review! I'd avoided PEP 7 for consistency with floor, but I just changed both

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Fedora Stable LTO + PGO 3.x has failed when building commit f013b47.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/29/builds/4915) and take a look at the build logs.
Check if the failure is related to this commit (f013b47) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/29/builds/4915

Failed tests:

test.test_concurrent_futures.test_shutdown

Failed subtests:

test_interpreter_shutdown - test.test_concurrent_futures.test_shutdown.ProcessPoolForkProcessPoolShutdownTest.test_interpreter_shutdown

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.lto-pgo/build/Lib/test/test_concurrent_futures/test_shutdown.py", line 50, in test_interpreter_shutdown
    self.assertEqual(out.strip(), b"apple")
AssertionError: b'' != b'apple'

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL8 FIPS Only Blake2 Builtin Hash 3.x has failed when building commit f013b47.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/469/builds/6217) and take a look at the build logs.
Check if the failure is related to this commit (f013b47) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/469/builds/6217

Failed tests:

test.test_multiprocessing_fork.test_processes

Summary of the results of the build (if available):

==

Click to see traceback logs

remote: Enumerating objects: 18, done.        
remote: Counting objects:   5% (1/18)        
remote: Counting objects:  11% (2/18)        
remote: Counting objects:  16% (3/18)        
remote: Counting objects:  22% (4/18)        
remote: Counting objects:  27% (5/18)        
remote: Counting objects:  33% (6/18)        
remote: Counting objects:  38% (7/18)        
remote: Counting objects:  44% (8/18)        
remote: Counting objects:  50% (9/18)        
remote: Counting objects:  55% (10/18)        
remote: Counting objects:  61% (11/18)        
remote: Counting objects:  66% (12/18)        
remote: Counting objects:  72% (13/18)        
remote: Counting objects:  77% (14/18)        
remote: Counting objects:  83% (15/18)        
remote: Counting objects:  88% (16/18)        
remote: Counting objects:  94% (17/18)        
remote: Counting objects: 100% (18/18)        
remote: Counting objects: 100% (18/18), done.        
remote: Compressing objects:   5% (1/18)        
remote: Compressing objects:  11% (2/18)        
remote: Compressing objects:  16% (3/18)        
remote: Compressing objects:  22% (4/18)        
remote: Compressing objects:  27% (5/18)        
remote: Compressing objects:  33% (6/18)        
remote: Compressing objects:  38% (7/18)        
remote: Compressing objects:  44% (8/18)        
remote: Compressing objects:  50% (9/18)        
remote: Compressing objects:  55% (10/18)        
remote: Compressing objects:  61% (11/18)        
remote: Compressing objects:  66% (12/18)        
remote: Compressing objects:  72% (13/18)        
remote: Compressing objects:  77% (14/18)        
remote: Compressing objects:  83% (15/18)        
remote: Compressing objects:  88% (16/18)        
remote: Compressing objects:  94% (17/18)        
remote: Compressing objects: 100% (18/18)        
remote: Compressing objects: 100% (18/18), done.        
remote: Total 18 (delta 4), reused 6 (delta 0), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to 'f013b475047b2e9d377feda9f2e16e5cdef824d7'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at f013b47504 gh-110489: Optimise math.ceil for known exact float (#108801)
Switched to and reset branch 'main'

make: *** [Makefile:2018: buildbottest] Error 5

) This matches a similar optimisation done for math.floor in python#21072

bedevere-bot added the awaiting core review label Sep 2, 2023

hauntsaninja mentioned this pull request Sep 2, 2023

gh-102837: few coverage nitpicks for the math module #102523

Merged

hauntsaninja requested a review from rhettinger September 2, 2023 05:39

skirpichev reviewed Sep 2, 2023

View reviewed changes

hauntsaninja force-pushed the ceil-optim branch from 3166603 to 7463f3a Compare September 3, 2023 08:49

hauntsaninja changed the title Optimise math.ceil for known exact float gh-110489: Optimise math.ceil for known exact float Oct 6, 2023

bedevere-app Bot mentioned this pull request Oct 6, 2023

Optimise math.ceil for known exact float #110489

Closed

hauntsaninja and others added 2 commits October 6, 2023 15:27

pep 7

5c46412

📜🤖 Added by blurb_it.

6c28b76

hauntsaninja enabled auto-merge (squash) October 6, 2023 22:53

hauntsaninja merged commit f013b47 into python:main Oct 6, 2023

bedevere-app Bot removed the awaiting core review label Oct 6, 2023

hauntsaninja deleted the ceil-optim branch October 6, 2023 23:12

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024

pythongh-110489 : Optimise math.ceil for known exact float (python#108801

f02d2a7

) This matches a similar optimisation done for math.floor in python#21072

                       if (PyErr_Occurred())
                           return NULL;
+                      x = PyFloat_AsDouble(number);
+                      if (x == -1.0 && PyErr_Occurred())

gh-110489: Optimise math.ceil for known exact float by hauntsaninja · Pull Request #108801 · python/cpython · GitHub

Uh oh!

Uh oh!

gh-110489: Optimise math.ceil for known exact float - #108801

gh-110489: Optimise math.ceil for known exact float#108801
hauntsaninja merged 3 commits into
python:mainfrom
hauntsaninja:ceil-optim

hauntsaninja commented Sep 2, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

Uh oh!

skirpichev Sep 2, 2023 •
edited
Loading

Uh oh!

Uh oh!

skirpichev Sep 3, 2023

Uh oh!

skirpichev Sep 2, 2023

Uh oh!

hauntsaninja commented Oct 6, 2023

Uh oh!

bedevere-bot commented Oct 6, 2023

Uh oh!

bedevere-bot commented Oct 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

+                  if (PyFloat_CheckExact(number)) {
+                      x = PyFloat_AS_DOUBLE(number);
+                  }
+                  else

gh-110489: Optimise math.ceil for known exact float by hauntsaninja · Pull Request #108801 · python/cpython · GitHub

Uh oh!

Uh oh!

gh-110489: Optimise math.ceil for known exact float - #108801

gh-110489: Optimise math.ceil for known exact float#108801hauntsaninja merged 3 commits intopython:mainpython/cpython:mainfrom hauntsaninja:ceil-optimhauntsaninja/cpython:ceil-optimCopy head branch name to clipboard

Conversation

hauntsaninja commented Sep 2, 2023 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skirpichev Sep 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

skirpichev Sep 3, 2023

Choose a reason for hiding this comment

Uh oh!

skirpichev Sep 2, 2023

Choose a reason for hiding this comment

Uh oh!

hauntsaninja commented Oct 6, 2023

Uh oh!

bedevere-bot commented Oct 6, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Oct 6, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gh-110489: Optimise math.ceil for known exact float#108801
hauntsaninja merged 3 commits into
python:mainfrom
hauntsaninja:ceil-optim

hauntsaninja commented Sep 2, 2023 •
edited by bedevere-app Bot
Loading

skirpichev Sep 2, 2023 •
edited
Loading