FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101100: Fix sphinx warnings in `unittest.mock-examples.rst` by sobolevn · Pull Request #108810 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-101100: Fix sphinx warnings in unittest.mock-examples.rst - #108810

Merged
AlexWaygood merged 3 commits into
python:mainfrom
sobolevn:issue-101100-mock-examples
Sep 2, 2023
ConversationCommits (3)ChecksFiles changed
Merged

gh-101100: Fix sphinx warnings in unittest.mock-examples.rst#108810
AlexWaygood merged 3 commits into
python:mainfrom
sobolevn:issue-101100-mock-examples

Conversation

sobolevn commented Sep 2, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request Sep 2, 2023
Closed
AlexWaygood reviewed Sep 2, 2023
View reviewed changes
Comment thread Doc/library/unittest.mock-examples.rst Outdated
AlexWaygood mentioned this pull request Sep 2, 2023
Merged
AlexWaygood approved these changes Sep 2, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

AlexWaygood added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 2, 2023
AlexWaygood merged commit 5141b1e into python:main Sep 2, 2023

miss-islington commented Sep 2, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

bedevere-bot commented Sep 2, 2023

Copy link
Copy Markdown

There's a new commit after the PR has been approved.

@AlexWaygood: please review the changes made to this pull request.

miss-islington commented Sep 2, 2023

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn and @AlexWaygood, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5141b1ebe07ad54279e0770b4704eaf76f24951d 3.12

miss-islington commented Sep 2, 2023

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn and @AlexWaygood, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5141b1ebe07ad54279e0770b4704eaf76f24951d 3.11

AlexWaygood commented Sep 2, 2023

Copy link
Copy Markdown
Member

@sobolevn, are you okay to take care of the backports? :)

bedevere-bot commented Sep 2, 2023

Copy link
Copy Markdown

GH-108812 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 2, 2023
sobolevn added a commit to sobolevn/cpython that referenced this pull request Sep 2, 2023
[3.11] pythongh-101100: Fix sphinx warnings in `unittest.mock-example…
402a645 
…s.rst` (pythonGH-108810)

(cherry picked from commit 5141b1e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
sobolevn added a commit to sobolevn/cpython that referenced this pull request Sep 2, 2023
[3.12] pythongh-101100: Fix sphinx warnings in `unittest.mock-example…
d74e296 
…s.rst` (pythonGH-108810).

(cherry picked from commit 5141b1e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

bedevere-bot commented Sep 2, 2023

Copy link
Copy Markdown

GH-108813 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Sep 2, 2023
AlexWaygood pushed a commit that referenced this pull request Sep 2, 2023
[3.11] gh-101100: Fix sphinx warnings in unittest.mock-examples.rst (…
662d236 
…GH-108810) (#108812)

(cherry picked from commit 5141b1e)
Yhg1s pushed a commit that referenced this pull request Sep 2, 2023
[3.12] gh-101100: Fix sphinx warnings in unittest.mock-examples.rst (…
c5ce34f 
…GH-108810) (#108813)

* [3.12] gh-101100: Fix sphinx warnings in `unittest.mock-examples.rst` (GH-108810).
(cherry picked from commit 5141b1e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

* Make the requested changes

---------

Co-authored-by: AlexWaygood <alex.waygood@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk Awaiting requested review from hugovk hugovk is a code owner
AlexWaygood Awaiting requested review from AlexWaygood

Assignees

AlexWaygood

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL