FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.7] bpo-35296: make install now installs the internal API (GH-10665) by vstinner · Pull Request #10897 · python/cpython · GitHub

/ cpython Public

[3.7] bpo-35296: make install now installs the internal API (GH-10665) - #10897

Merged
vstinner merged 2 commits into
python:3.7from
vstinner:install_internals
Dec 4, 2018
ConversationCommits (2)ChecksFiles changed
Merged

[3.7] bpo-35296: make install now installs the internal API (GH-10665)#10897
vstinner merged 2 commits into
python:3.7from
vstinner:install_internals

Conversation

vstinner commented Dec 4, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

https://bugs.python.org/issue35296

bpo-35296: make install now installs the internal API (GH-10665)
9914eb7 
make install now also installs the internal API: Include/internal/*.h
header files.

(cherry picked from commit f653fd4)
Windows installer now also install Include/internal/
72e37f9 
The Windows installer (MSI) now also install header files of the
Include/internal/ subdirectory.
vstinner requested a review from a team as a code owner December 4, 2018 16:12
vstinner requested review from pitrou and zooba December 4, 2018 16:15

vstinner commented Dec 4, 2018

Copy link
Copy Markdown
Member Author

@zooba: I already modified the installer in master, but here I would like to make the same change in Python 3.7.

zooba approved these changes Dec 4, 2018
View reviewed changes

zooba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Approved the Windows part of the change.

vstinner merged commit b02774f into python:3.7 Dec 4, 2018
vstinner deleted the install_internals branch December 4, 2018 20:28

vstinner commented Dec 4, 2018

Copy link
Copy Markdown
Member Author

@pitrou approved the backport by email: https://mail.python.org/pipermail/python-dev/2018-December/155922.html

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zooba zooba approved these changes
pitrou Awaiting requested review from pitrou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL