C API tests: use special markers to test that output parameters were set - #109014
Merged
serhiy-storchaka merged 2 commits intoSep 6, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
vstinner
approved these changes
Sep 6, 2023
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. I just propose a less common value for UNINITIALIZED_INT and UNINITIALIZED_SIZE.
I used random.randint(0, 2**30) to generate the two numbers that I proposed.
Sorry, something went wrong.
Comment thread
Modules/_testcapi/util.h
Outdated
Comment thread
Modules/_testcapi/util.h
Comment thread
Modules/_testcapi/util.h
Outdated
Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Copy Markdown
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict. |
Sorry, something went wrong.
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Sep 6, 2023
…s were set (pythonGH-109014). (cherry picked from commit bf414b7) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Copy link
Copy Markdown
|
GH-109023 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
This change introduced compiler warnings on FreeBSD (clang -O2): ../Modules/_testcapimodule.c:225:18: warning: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Wstring-compare]
assert(k != UNINITIALIZED_PTR);
^ ~~~~~~~~~~~~~~~~~
/usr/include/assert.h:56:21: note: expanded from macro 'assert'
#define assert(e) ((e) ? (void)0 : __assert(__func__, __FILE__, \
^
../Modules/_testcapimodule.c:226:18: warning: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Wstring-compare]
assert(v != UNINITIALIZED_PTR);
^ ~~~~~~~~~~~~~~~~~
/usr/include/assert.h:56:21: note: expanded from macro 'assert'
#define assert(e) ((e) ? (void)0 : __assert(__func__, __FILE__, \
^
../Modules/_testcapimodule.c:238:14: warning: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Wstring-compare]
assert(k == UNINITIALIZED_PTR);
^ ~~~~~~~~~~~~~~~~~
/usr/include/assert.h:56:21: note: expanded from macro 'assert'
#define assert(e) ((e) ? (void)0 : __assert(__func__, __FILE__, \
^
../Modules/_testcapimodule.c:239:14: warning: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Wstring-compare]
assert(v == UNINITIALIZED_PTR);
^ ~~~~~~~~~~~~~~~~~
/usr/include/assert.h:56:21: note: expanded from macro 'assert'
#define assert(e) ((e) ? (void)0 : __assert(__func__, __FILE__, \
^
--- Modules/_testcapi/dict.o ---
cc -pthread -fno-strict-overflow -Wsign-compare -g -Og -Wall -O2 -pipe -std=c11 -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wstrict-prototypes -Werror=implicit-function-declaration -fvisibility=hidden -I../Include/internal -IObjects -IInclude -IPython -I. -I../Include -fPIC -c ../Modules/_testcapi/dict.c -o Modules/_testcapi/dict.o
../Modules/_testcapi/dict.c:289:16: warning: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Wstring-compare]
assert(key == UNINITIALIZED_PTR);
^ ~~~~~~~~~~~~~~~~~
/usr/include/assert.h:56:21: note: expanded from macro 'assert'
#define assert(e) ((e) ? (void)0 : __assert(__func__, __FILE__, \
^
../Modules/_testcapi/dict.c:290:18: warning: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Wstring-compare]
assert(value == UNINITIALIZED_PTR);
^ ~~~~~~~~~~~~~~~~~
/usr/include/assert.h:56:21: note: expanded from macro 'assert'
#define assert(e) ((e) ? (void)0 : __assert(__func__, __FILE__, \
^
2 warnings generated.
--- Modules/_testcapi/exceptions.o ---
../Modules/_testcapi/exceptions.c:129:17: warning: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Wstring-compare]
assert(type != UNINITIALIZED_PTR);
^ ~~~~~~~~~~~~~~~~~
/usr/include/assert.h:56:21: note: expanded from macro 'assert'
#define assert(e) ((e) ? (void)0 : __assert(__func__, __FILE__, \
^
../Modules/_testcapi/exceptions.c:130:18: warning: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Wstring-compare]
assert(value != UNINITIALIZED_PTR);
^ ~~~~~~~~~~~~~~~~~
/usr/include/assert.h:56:21: note: expanded from macro 'assert'
#define assert(e) ((e) ? (void)0 : __assert(__func__, __FILE__, \
^
../Modules/_testcapi/exceptions.c:131:15: warning: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Wstring-compare]
assert(tb != UNINITIALIZED_PTR);
^ ~~~~~~~~~~~~~~~~~
/usr/include/assert.h:56:21: note: expanded from macro 'assert'
#define assert(e) ((e) ? (void)0 : __assert(__func__, __FILE__, \
^
I'm not sure if I copied correctly all warnings. build: https://cirrus-ci.com/task/5026392602050560?logs=build#L79 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended extraction from #108797. It will be backported, unlike to the main part of #108797.