FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-109256: allocate opcode IDs for internal opcodes in their own range by iritkatriel · Pull Request #109269 · python/cpython · GitHub

/ cpython Public

gh-109256: allocate opcode IDs for internal opcodes in their own range - #109269

Merged
iritkatriel merged 5 commits into
python:mainfrom
iritkatriel:internal_ops
Sep 12, 2023
ConversationCommits (5)ChecksFiles changed
Merged

gh-109256: allocate opcode IDs for internal opcodes in their own range#109269
iritkatriel merged 5 commits into
python:mainfrom
iritkatriel:internal_ops

Conversation

iritkatriel commented Sep 11, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

iritkatriel changed the title gh-09256: allocate opcode IDs for internal opcodes in their own range gh-109256: allocate opcode IDs for internal opcodes in their own range Sep 11, 2023
bedevere-app Bot mentioned this pull request Sep 11, 2023
Closed
markshannon reviewed Sep 11, 2023
View reviewed changes

markshannon left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good, in general.

test_dis will need fixing up, of course.

As you need to fix test_dis anyway could you make RESUME opcode 1? If it is to have a special number, it might as well be memorable.

    map_op(1, "RESUME")
    next_opcode = 2

iritkatriel commented Sep 11, 2023

Copy link
Copy Markdown
Member Author

Looks good, in general.

test_dis will need fixing up, of course.

As you need to fix test_dis anyway could you make RESUME opcode 1? If it is to have a special number, it might as well be memorable.

    map_op(1, "RESUME")
    next_opcode = 2

RESUME has an arg though, so I thought it should be after HAVE_ARGUMENT? Unless we want to special case it.

brettcannon removed their request for review September 11, 2023 22:48
markshannon self-requested a review September 12, 2023 08:26
markshannon approved these changes Sep 12, 2023
View reviewed changes

markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good. Should save a fair bit of future churn.
Merge conflicts need fixing, obviously.

markshannon mentioned this pull request Sep 12, 2023
Closed
iritkatriel enabled auto-merge (squash) September 12, 2023 10:12
iritkatriel merged commit 8b55adf into python:main Sep 12, 2023
gvanrossum mentioned this pull request Sep 12, 2023
Merged
vstinner pushed a commit to vstinner/cpython that referenced this pull request Sep 13, 2023
pythongh-109256: allocate opcode IDs for internal opcodes in their ow…
547afcc 
…n range (python#109269)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

markshannon markshannon approved these changes
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL