| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Builtin functions and methods that have non-representable signatures today will have representable signatures yesterday, and they will become unusable for testing this feature. So we need to add special functions and methods to the _testcapi module that always have non-representable signatures.
|
I do not understand why Tools/c-analyzer/check-c-globals.py complains about DocStringUnrepresentableSignatureTest, but not about DocStringNoSignatureTest in Modules/_testcapi/docstring.c. They are almost identical, only names and methods are different. Both are added by me, so there is no any special magic hidden. @ericsnowcurrently, could you explain this? |
Sorry, something went wrong.
|
Unfortunately, the tool never learned to reliably identify implicitly-const static definitions (e.g. Py*Def arrays/structs like the PyMethodDef one you added in this PR). Instead, such variables usually have to be manually added to Tools/c-analyzer/cpython/ignored.tsv. DocStringNoSignatureTest was added there a while back. You can move the entry you added to globals-to-fix.tsv over to ignored.tsv. |
Sorry, something went wrong.
|
Thank you Eric. I did not know about ignored.tsv. |
Sorry, something went wrong.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry, something went wrong.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, something went wrong.
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict. |
Sorry, something went wrong.
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict. |
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot PPC64LE RHEL8 LTO 3.x has failed when building commit 1f885df. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/361/builds/4050 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/test/test_asyncio/test_subprocess.py", line 788, in test_subprocess_consistent_callbacks
self.loop.run_until_complete(main())
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/base_events.py", line 664, in run_until_complete
return future.result()
^^^^^^^^^^^^^^^
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/test/test_asyncio/test_subprocess.py", line 780, in main
self.assertEqual(events, [
AssertionError: Lists differ: [('pi[29 chars]t'), 'pipe_connection_lost', ('pipe_data_recei[57 chars]ted'] != [('pi[29 chars]t'), ('pipe_data_received', 2, b'stderr'), 'pi[57 chars]ted']
|
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Builtin functions and methods that have non-representable signatures today will have representable signatures yesterday, and they will become unusable for testing this feature.
So we need to add special functions and methods to the _testcapi module that always have non-representable signatures.